-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new onboarding experience #1250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cescoferraro I found a weird visual bug
Also, when clicking outside the onboarding popup it closes and ends the onboarding process.
And when you click prev the positions are wrong.
@jorgeepc @xoscar the issue reported by oscar in the last comment is because our different modes (Trigger/Trace/Test) are placed on different URLs. |
a8fc326
to
44867d9
Compare
@cescoferraro I'm still seeing the weird behavior on some of the steps where it starts to shake. It also still has the issue that clicking elsewhere on the screen would close the onboarding. |
@xoscar but closing when clicking elsewhere on the screen is the default behavior. |
44867d9
to
0426df3
Compare
This reverts commit 858a836.
58baf32
to
aead45a
Compare
aead45a
to
cd76b1b
Compare
"react-json-view": "1.21.3", | ||
"react-redux": "7.2.6", | ||
"react-reflex": "4.0.9", | ||
"react-router-dom": "6.2.1", | ||
"react-scripts": "5.0.1", | ||
"react-syntax-highlighter": "15.5.0", | ||
"react-use": "17.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the react tour dependency if we are not using it anymore?
fix show to new users feature make callback part of the provider state replace @reactour/tour with joyride add skip button
cd76b1b
to
32e4b38
Compare
32e4b38
to
2bee5b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre approving, GJ @cescoferraro
This PR creates the new onboarding expirience by this design https://www.figma.com/file/TMShLwGmcTwX7uRodvyRoE/Onboarding
Changes
Checklist