Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new onboarding experience #1250

Merged
merged 7 commits into from
Oct 5, 2022
Merged

Create new onboarding experience #1250

merged 7 commits into from
Oct 5, 2022

Conversation

cescoferraro
Copy link
Contributor

This PR creates the new onboarding expirience by this design https://www.figma.com/file/TMShLwGmcTwX7uRodvyRoE/Onboarding

Changes

  • Add New design

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Copy link
Contributor

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cescoferraro I found a weird visual bug

2022-09-20 16 48 05

Also, when clicking outside the onboarding popup it closes and ends the onboarding process.
And when you click prev the positions are wrong.

@jorgeepc jorgeepc changed the title Create new onboarding expirience Create new onboarding experience Sep 20, 2022
@cescoferraro
Copy link
Contributor Author

@jorgeepc @xoscar the issue reported by oscar in the last comment is because our different modes (Trigger/Trace/Test) are placed on different URLs.
So when the onboarding goes from one URL to another, the next step component is not rendered. So the tour does not know where to place the dialog.
To solve the issue I have added 2 other steps, so we can showcase the Tabs Header while we navigate to the Test Mode so the glitch does not work on the proposed onboarding.

@xoscar
Copy link
Contributor

xoscar commented Sep 28, 2022

@cescoferraro I'm still seeing the weird behavior on some of the steps where it starts to shake. It also still has the issue that clicking elsewhere on the screen would close the onboarding.

@cescoferraro
Copy link
Contributor Author

@xoscar but closing when clicking elsewhere on the screen is the default behavior.
The shaking thing is hard to prevent when switching URLs. I think I need to give it a try with another library.
There is no way of making react-tour delay the navigating before presenting the new step.

"react-json-view": "1.21.3",
"react-redux": "7.2.6",
"react-reflex": "4.0.9",
"react-router-dom": "6.2.1",
"react-scripts": "5.0.1",
"react-syntax-highlighter": "15.5.0",
"react-use": "17.4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the react tour dependency if we are not using it anymore?

fix show to new users feature

make callback part of the provider state

replace @reactour/tour with joyride

add skip button
Copy link
Contributor

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre approving, GJ @cescoferraro

@cescoferraro cescoferraro merged commit 019f414 into main Oct 5, 2022
@cescoferraro cescoferraro deleted the feat/new-onboarding branch October 5, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants