fix: move timer outside loops #5880
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sandbox environment for URLs
|
exu
commented
Sep 30, 2024
| @@ -272,19 +273,31 @@ func (ag *Agent) sendResponse(ctx context.Context, stream cloud.TestKubeCloudAPI | |||
| } | |||
| } | |||
|
|
|||
| func (ag *Agent) newTimeoutTimer() { | |||
There was a problem hiding this comment.
Will it work between go routines?
exu
commented
Sep 30, 2024
| var cmd *cloud.ExecuteRequest | ||
| select { | ||
| case resp := <-respChan: | ||
| if !t.Stop() { | ||
| <-t.C | ||
| if !ag.timeoutTimer.Stop() { |
There was a problem hiding this comment.
should it be synced ? it can panic in some use cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Checklist (choose whats happened)
Breaking changes
Changes
Fixes