feat: trigger concurrency policy

apis/testtriggers/v1/testtrigger_types.go

@@ -57,6 +57,8 @@ type TestTriggerSpec struct {
 	Execution TestTriggerExecution `json:"execution"`
 	// TestSelector identifies on which Testkube Kubernetes Objects an Action should be taken
 	TestSelector TestTriggerSelector `json:"testSelector"`
+	// ConcurrencyPolicy defines concurrency policy for selected Execution
+	ConcurrencyPolicy TestTriggerConcurrencyPolicy `json:"concurrencyPolicy"`
 	// Delay is a duration string which specifies how long should the test be delayed after a trigger is matched
 	// +kubebuilder:validation:Type:=string
 	// +kubebuilder:validation:Format:=duration
@@ -113,6 +115,17 @@ const (
 	TestTriggerExecutionTestsuite TestTriggerExecution = "testsuite"
 )
 
+// TestTriggerConcurrencyPolicy defines concurrency policy for test triggers
+// +kubebuilder:validation:Enum=allow;forbid;replace
+type TestTriggerConcurrencyPolicy string
+
+// List of TestTriggerConcurrencyPolicy
+const (
+	TestTriggerConcurrencyPolicyAllow   TestTriggerConcurrencyPolicy = "allow"
+	TestTriggerConcurrencyPolicyForbid  TestTriggerConcurrencyPolicy = "forbid"
+	TestTriggerConcurrencyPolicyReplace TestTriggerConcurrencyPolicy = "replace"
+)
+
 // TestTriggerSelector is used for selecting Kubernetes Objects
 type TestTriggerSelector struct {
 	// Name selector is used to identify a Kubernetes Object based on the metadata name

config/crd/bases/tests.testkube.io_testtriggers.yaml

@@ -54,6 +54,14 @@ spec:
                 enum:
                 - run
                 type: string
+              concurrencyPolicy:
+                description: ConcurrencyPolicy defines concurrency policy for selected
+                  Execution
+                enum:
+                - allow
+                - forbid
+                - replace
+                type: string
               conditionSpec:
                 description: What resource conditions should be matched
                 properties:
@@ -293,6 +301,7 @@ spec:
                 type: object
             required:
             - action
+            - concurrencyPolicy
             - event
             - execution
             - resource

controllers/testtriggers/testtrigger_validator.go

@@ -61,6 +61,10 @@ func (v *Validator) ValidateCreate(ctx context.Context, t *testtriggerv1.TestTri
 		allErrs = append(allErrs, err)
 	}
 
+	if err := v.validateConcurrencyPolicy(t.Spec.ConcurrencyPolicy); err != nil {
+		allErrs = append(allErrs, err)
+	}
+
 	if err := v.validateResourceSelector(t.Spec.ResourceSelector); err != nil {
 		allErrs = append(allErrs, err...)
 	}
@@ -106,6 +110,10 @@ func (v *Validator) ValidateUpdate(ctx context.Context, old runtime.Object, new
 		allErrs = append(allErrs, err)
 	}
 
+	if err := v.validateConcurrencyPolicy(new.Spec.ConcurrencyPolicy); err != nil {
+		allErrs = append(allErrs, err)
+	}
+
 	if errs := v.validateResourceSelector(new.Spec.ResourceSelector); errs != nil {
 		allErrs = append(allErrs, errs...)
 	}
@@ -208,6 +216,14 @@ func (v *Validator) validateExecution(execution testtriggerv1.TestTriggerExecuti
 	return nil
 }
 
+func (v *Validator) validateConcurrencyPolicy(concurrencyPlociy testtriggerv1.TestTriggerConcurrencyPolicy) *field.Error {
+	if !utils.In(string(concurrencyPlociy), testtrigger.GetSupportedConcurrencyPolicies()) {
+		fld := field.NewPath("spec").Child("concurrencyPolicy")
+		return field.NotSupported(fld, concurrencyPlociy, testtrigger.GetSupportedConcurrencyPolicies())
+	}
+	return nil
+}
+
 func (v *Validator) validateConditions(conditionSpec *testtriggerv1.TestTriggerConditionSpec) field.ErrorList {
 	var allErrs field.ErrorList
 	if conditionSpec == nil {

controllers/testtriggers/testtrigger_validator_test.go

@@ -69,6 +69,26 @@ func TestValidator_validateExecution(t *testing.T) {
 	})
 }
 
+func TestValidator_validateConcurrencyPlocy(t *testing.T) {
+	t.Parallel()
+
+	v := NewValidator(buildFakeK8sClient(t))
+
+	t.Run("no error for valid concurrency policy", func(t *testing.T) {
+		t.Parallel()
+
+		err := v.validateConcurrencyPolicy("allow")
+		assert.Nil(t, err)
+	})
+
+	t.Run("error for invalid concurrency policy", func(t *testing.T) {
+		t.Parallel()
+
+		err := v.validateConcurrencyPolicy("skip")
+		assert.ErrorContains(t, err, "spec.concurrencyPolicy: Unsupported value: \"skip\"")
+	})
+}
+
 func TestValidator_validateResource(t *testing.T) {
 	t.Parallel()
 

pkg/validation/tests/v1/testtrigger/types.go

@@ -8,6 +8,9 @@ const (
 	ExecutionTest                               = "test"
 	ExecutionTestsuite                          = "testsuite"
 	ActionRun                                   = "run"
+	ConcurrencyPolicyAllow                      = "allow"
+	ConcurrencyPolicyForbid                     = "forbid"
+	ConcurrencyPolicyReplace                    = "replace"
 	ResourcePod                                 = "pod"
 	ResourceDeployment                          = "deployment"
 	ResourceStatefulSet                         = "statefulset"

pkg/validation/tests/v1/testtrigger/util.go

@@ -25,6 +25,10 @@ func GetSupportedExecutions() []string {
 	return []string{ExecutionTest, ExecutionTestsuite}
 }
 
+func GetSupportedConcurrencyPolicies() []string {
+	return []string{ConcurrencyPolicyAllow, ConcurrencyPolicyForbid, ConcurrencyPolicyReplace}
+}
+
 func GetSupportedConditionStatuses() []string {
 	return []string{
 		string(testtriggerv1.TRUE_TestTriggerConditionStatuses),