Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update root /proxy path #7902

Merged
merged 1 commit into from
Apr 9, 2018
Merged

update root /proxy path #7902

merged 1 commit into from
Apr 9, 2018

Conversation

CaoShuFeng
Copy link
Contributor

Fix issue: kubernetes/kubernetes#61826
Related change: kubernetes/kubernetes#59884

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.10 Features: set Milestone to 1.10 and Base Branch to release-1.10
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box so that maintainers can work on your patch and speed up the review process. This is a temporary workaround to address a known issue with GitHub.>

Please delete this note before submitting the pull request.

Allow edits from maintainers checkbox

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2018
@CaoShuFeng
Copy link
Contributor Author

/assign @mikedanese
For tech review.

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8e24cb3

https://deploy-preview-7902--kubernetes-io-master-staging.netlify.com

@CaoShuFeng CaoShuFeng changed the title fix description about root /proxy path update root /proxy path Mar 29, 2018
@Bradamant3
Copy link
Contributor

Bradamant3 commented Mar 29, 2018 •
edited
Loading

/approve for docs

@mikedanese if it looks good to you, add an /lgtm and we'll get it merged. Thanks!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2018
tengqm
tengqm approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0cc8592 into kubernetes:master Apr 9, 2018
@tengqm tengqm mentioned this pull request Apr 9, 2018
Closed
2 tasks
@mtaufen
Copy link
Contributor

mtaufen commented Apr 9, 2018

Thanks!

zacharysarah pushed a commit that referenced this pull request Apr 16, 2018
@CaoShuFeng
fix description about root /proxy path (#7902)
00858a8 
Fix issue: kubernetes/kubernetes#61826
Related change: kubernetes/kubernetes#59884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm approved these changes

@mtaufen mtaufen Awaiting requested review from mtaufen

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@mikedanese mikedanese

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@CaoShuFeng @k8sio-netlify-preview-bot @Bradamant3 @k8s-ci-robot @mtaufen @tengqm @mikedanese