-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding the FQDN for example. #7872
Conversation
adding the FQDN for example.
/assign @tengqm |
Deploy preview for kubernetes-io-master-staging ready! Built with commit f551147 https://deploy-preview-7872--kubernetes-io-master-staging.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@fqsghostcloud @tengqm sorry to hold this one up, but every time I see a URL that we don't control and would need to monitor to keep up-to-date, I worry. Does this information add sufficient value to warrant the risk of the link changing without us knowing about the change? Also, it's not the FQDN of the individual private docker registry -- it can't be, because that's known only to the owners of the registry. /assign |
@Bradamant3 I think this is okay. They are just specifying the value to use for DockerHub, which is commonly used. I've seen another PR for this, so I think there's a need. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenopis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adding the FQDN for example.