Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the FQDN for example. #7872

Merged
merged 1 commit into from
Apr 26, 2018
Merged

adding the FQDN for example. #7872

merged 1 commit into from
Apr 26, 2018

Conversation

fqsghostcloud
Copy link
Contributor

adding the FQDN for example.

adding the FQDN for  example.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 27, 2018
@fqsghostcloud
Copy link
Contributor Author

/assign @tengqm

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f551147

https://deploy-preview-7872--kubernetes-io-master-staging.netlify.com

Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2018
@Bradamant3
Copy link
Contributor

@fqsghostcloud @tengqm sorry to hold this one up, but every time I see a URL that we don't control and would need to monitor to keep up-to-date, I worry. Does this information add sufficient value to warrant the risk of the link changing without us knowing about the change? Also, it's not the FQDN of the individual private docker registry -- it can't be, because that's known only to the owners of the registry.
Can you explain why we need this change? Thanks!

/assign

@chenopis
Copy link
Contributor

@Bradamant3 I think this is okay. They are just specifying the value to use for DockerHub, which is commonly used. I've seen another PR for this, so I think there's a need.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenopis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2018
@k8s-ci-robot k8s-ci-robot merged commit c47d235 into kubernetes:master Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants