modify the default update strategy of statefulset #7270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 2f09ce5 https://deploy-preview-7270--kubernetes-io-master-staging.netlify.com |
|
/assign @enisoc |
tengqm
reviewed
Feb 7, 2018
enisoc
approved these changes
Feb 7, 2018
There was a problem hiding this comment.
/lgtm
@tengqm The default changed as of apps/v1beta2 in Kubernetes 1.8:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.8.md#defaults
| `.spec.updateStrategy.type` is set to `OnDelete`, the StatefulSet controller will not automatically | ||
| update the Pods in a StatefulSet. Users must manually delete Pods to cause the controller to | ||
| create new Pods that reflect modifications made to a StatefulSet's `.spec.template`. | ||
|
|
||
| ### Rolling Updates | ||
|
|
||
| The `RollingUpdate` update strategy implements automated, rolling update for the Pods in a | ||
| StatefulSet. When a StatefulSet's `.spec.updateStrategy.type` is set to `RollingUpdate`, the | ||
| StatefulSet. It is the default strategy when `spec.updateStrategy` is left unspecified. When a StatefulSet's `.spec.updateStrategy.type` is set to `RollingUpdate`, the |
There was a problem hiding this comment.
Nit: please wrap "When a ..." to a new line.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enisoc, Pingan2017 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
chenopis
added a commit
that referenced
this pull request
Feb 8, 2018
* 'master' of https://github.com/kubernetes/website: (379 commits) fix some typos in keps.md (#7266) Typo fix: recommend -> recommended (#7271) Update nodes.md (#7288) Fix patch image command in rolling update section (#7124) fix edx link (#7276) Update OWNERS_ALIASES for sig-openstack (#7280) Update ISSUE_TEMPLATE.md (#7284) Add Brad Topol to owner aliases. (#7246) modify the default update strategy of statefulset (#7270) Fix tags of workloads-related glossary (#7102) kubectl 1.9+ updated registry secret type and datakey: .dockercfg is now .dockerconfigjson, and datakey now wrapped in 'auths' element (#7248) Remove CentOS guide that was already deprecated a while ago (#7242) fix typo (#7260) fix typo envrionment -> [environment] (#7262) fix a typo in kubernetes api (#7261) fix some typos (#7251) Update notes.md (#7259) Update notes.md (#7257) Fix file extension and remove not necessary sudo. (#7143) Update Azure Container Service to managed clusters (#6955) ...
tehut
pushed a commit
to tehut/website
that referenced
this pull request
Feb 20, 2018
bsalamat
pushed a commit
to bsalamat/kubernetes.github.io
that referenced
this pull request
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is