Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpu request limit exmaples use the default namespace #6980

Merged

Conversation

nashasha1
Copy link
Contributor

@nashasha1 nashasha1 commented Jan 16, 2018

Specify the namespace to cpu-example. So, users can copy the yaml and run the task directly.

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jan 16, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 91a3f5f

https://deploy-preview-6980--kubernetes-io-master-staging.netlify.com

Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not necessary since the yaml files are part of the following page:
https://kubernetes.io/docs/tasks/configure-pod-container/assign-cpu-resource/

where each command examples there already explicitly specifies the namespace to use.

@nashasha1
Copy link
Contributor Author

@tengqm Thanks for your review. But now, users need to specify namespace in every yaml if they want to complete the whole task that is really inconvenient . After pr, people could copy the yaml directly.

@nashasha1 nashasha1 closed this Jan 17, 2018
@nashasha1 nashasha1 reopened this Jan 17, 2018
@tengqm
Copy link
Contributor

tengqm commented Jan 17, 2018

@nashasha1 I wasn't saying this is not correct or unacceptable. I was feeling a trade-off here. You may want to hard code the namespace into a resource manifest for convenience. Next time, when you want to do the same thing in a different namespace, you will need to change the manifest.
So, I'm neutral here.

@nashasha1
Copy link
Contributor Author

@tengqm Oh I see. thanks for your reply.
I thought the yaml is unique. it belongs to this task. no other places refer it. If users want to use it in other places, they should know replace the namespace.

@nashasha1
Copy link
Contributor Author

ping @abiogenesis-now

@heckj
Copy link
Contributor

heckj commented Feb 18, 2018

hi @nashasha1 - would you restrict this to the non cn/ content? I would love to have the same content applied to kubernetes/kubernetes-docs-cn. but don't want to mix them within a single PR

/assign

@nashasha1
Copy link
Contributor Author

@heckj Done. Thanks for your reply.

@heckj
Copy link
Contributor

heckj commented Feb 19, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heckj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit 194835e into kubernetes:master Feb 19, 2018
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
tehut pushed a commit to tehut/website that referenced this pull request Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants