-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cpu request limit exmaples use the default namespace #6980
Fix cpu request limit exmaples use the default namespace #6980
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 91a3f5f https://deploy-preview-6980--kubernetes-io-master-staging.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not necessary since the yaml files are part of the following page:
https://kubernetes.io/docs/tasks/configure-pod-container/assign-cpu-resource/
where each command examples there already explicitly specifies the namespace to use.
@tengqm Thanks for your review. But now, users need to specify namespace in every yaml if they want to complete the whole task that is really inconvenient . After pr, people could copy the yaml directly. |
@nashasha1 I wasn't saying this is not correct or unacceptable. I was feeling a trade-off here. You may want to hard code the namespace into a resource manifest for convenience. Next time, when you want to do the same thing in a different namespace, you will need to change the manifest. |
@tengqm Oh I see. thanks for your reply. |
ping @abiogenesis-now |
hi @nashasha1 - would you restrict this to the non /assign |
a00864a
to
91a3f5f
Compare
@heckj Done. Thanks for your reply. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: heckj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Specify the namespace to
cpu-example
. So, users can copy the yaml and run the task directly.This change is