Skip to content

Improve dark mode readability for Kubernetes Basics diagrams#56037

Merged
k8s-ci-robot merged 1 commit into
kubernetes:mainfrom
divyanshuprakas-h:fix-k8s-basics-dark-mode-images
Jun 10, 2026
Merged

Improve dark mode readability for Kubernetes Basics diagrams#56037
k8s-ci-robot merged 1 commit into
kubernetes:mainfrom
divyanshuprakas-h:fix-k8s-basics-dark-mode-images

Conversation

@divyanshuprakas-h

@divyanshuprakas-h divyanshuprakas-h commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes the dark mode readability issue in the “Learn Kubernetes Basics” tutorial.

Some SVG diagrams used dark text on a transparent background. In dark mode, the page background becomes dark, so the diagram text becomes difficult to read.

This PR updates the affected SVG diagrams directly by adding a stable white background inside the SVGs. This keeps the diagram text readable in both light mode and dark mode without changing the site-wide dark mode CSS.

Pages checked

I verified the affected tutorial pages locally in dark mode:

  • create-cluster
  • deploy-app
  • explore
  • scale
  • update

Testing

Tested locally with the Kubernetes website preview in dark mode.

Related issue

Fixes #56026

Signed-off-by: Divyanshu Prakash <divyanshuprakash914@gmail.com>
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 6, 2026
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 6, 2026
@netlify

netlify Bot commented Jun 6, 2026

Copy link
Copy Markdown

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 212b9ae
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6a23b5bdd8958e0008b8eed2
😎 Deploy Preview https://deploy-preview-56037--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Caesarsage

Copy link
Copy Markdown
Contributor

Hello @divyanshuprakas-h

Thank you for fixing this. Can you provide preview link to the page so it's easier for reviewers to checkout quickly

@Caesarsage

Copy link
Copy Markdown
Contributor

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 0580db41a2e89c0a2ca16835d877328f87eef6c8

@divyanshuprakas-h

Copy link
Copy Markdown
Contributor Author

@lmktfy

lmktfy commented Jun 10, 2026

Copy link
Copy Markdown
Member

Thanks

Making this change makes the site easier to access.


Perhaps one day we can get these diagrams redrawn; they are dated and it would be great to have them automatically adapt to light / dark mode. Right now, this simple change is an obvious improvement for people who set their browser to prefer a dark web page appearance.

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2026
@k8s-ci-robot k8s-ci-robot merged commit 5f0634b into kubernetes:main Jun 10, 2026
6 checks passed
@divyanshuprakas-h

Copy link
Copy Markdown
Contributor Author

Thanks i will continue contributing..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tutorials] Learn Kubernetes Basics: Text in Images Unreadable in Dark Mode

4 participants