Improve dark mode readability for Kubernetes Basics diagrams#56037
Conversation
Signed-off-by: Divyanshu Prakash <divyanshuprakash914@gmail.com>
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hello @divyanshuprakas-h Thank you for fixing this. Can you provide preview link to the page so it's easier for reviewers to checkout quickly |
|
LGTM label has been added. DetailsGit tree hash: 0580db41a2e89c0a2ca16835d877328f87eef6c8 |
|
Hi @Caesarsage, sure. Thanks for checking. Here are the deploy preview links for the affected tutorial pages:
I verified these pages in dark mode locally, and the diagrams are now readable against the dark background. Please let me know if anything needed to be improved.. |
|
Thanks Making this change makes the site easier to access. Perhaps one day we can get these diagrams redrawn; they are dated and it would be great to have them automatically adapt to light / dark mode. Right now, this simple change is an obvious improvement for people who set their browser to prefer a dark web page appearance. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks i will continue contributing.. |
Description
This PR fixes the dark mode readability issue in the “Learn Kubernetes Basics” tutorial.
Some SVG diagrams used dark text on a transparent background. In dark mode, the page background becomes dark, so the diagram text becomes difficult to read.
This PR updates the affected SVG diagrams directly by adding a stable white background inside the SVGs. This keeps the diagram text readable in both light mode and dark mode without changing the site-wide dark mode CSS.
Pages checked
I verified the affected tutorial pages locally in dark mode:
create-clusterdeploy-appexplorescaleupdateTesting
Tested locally with the Kubernetes website preview in dark mode.
Related issue
Fixes #56026