-
Notifications
You must be signed in to change notification settings - Fork 15.3k
blog: introducing node-readiness-controller #54112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: introducing node-readiness-controller #54112
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
fabriziopandini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool project!
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
0d9c4ed to
4cb0c82
Compare
|
Great job! |
|
LGTM label has been added. DetailsGit tree hash: 83a03411eb7fca621fcf69edc08e3a615e1a97c5 |
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I have added some inline feedback.
Across the article overall, the headings (but not the blog article title) should be in sentence case.
Example: "Core concepts and features" not "Core Concepts and Features".
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Show resolved
Hide resolved
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
...g/_posts/2026-01-26-introducing-node-readiness-controller/node-readiness-controller-logo.svg
Show resolved
Hide resolved
Arhell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to fix.
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Show resolved
Hide resolved
| enforcementMode: "bootstrap-only" | ||
| nodeSelector: | ||
| matchLabels: | ||
| node-role.kubernetes.io/worker: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if they have used this key but with the value "true"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The taint block in the rule spec defines the exact taint (key, value and effect) that the controller will apply to a node when its custom readiness conditions are not met.
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
|
/assign @lmktfy |
fabriziopandini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
/lgtm
|
LGTM label has been added. DetailsGit tree hash: e8cb1985927513c69db7f2a1a5bc79a11b10b739 |
content/en/blog/_posts/2026-01-26-introducing-node-readiness-controller/index.md
Outdated
Show resolved
Hide resolved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 6ca59d6281e58678c5ce06e62faf174bbf2a4d0d |
|
/label tide/merge-method-squash |
Description
A blog post draft for announcing the Node Readiness Controller project and introduce its features.
Issue
Closes: ##54104