-
Notifications
You must be signed in to change notification settings - Fork 15.2k
feat(blog): feature blog for watch based routes reconciliation #52973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blog): feature blog for watch based routes reconciliation #52973
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @lukasmetzner thank you for opening this feature blog placeholder PR. Thank you :) |
70e0315 to
feb5b0d
Compare
feb5b0d to
05faef6
Compare
|
thanks @lukasmetzner ! |
|
The implementation is not merged yet. I would put it to hold, correct me if I am wrong here 😅 Content-wise it would be ready for a review from my side ^^ /hold |
elmiko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is straightfoward and to the point. i have a couple suggestions for the intro paragraph, and a couple minor nits.
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Show resolved
Hide resolved
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Show resolved
Hide resolved
|
actually, i just noticed the commits. @lukasmetzner can we squash this to a single commit please. /unlgtm |
efb50a2 to
5690a66
Compare
5690a66 to
be4d4f0
Compare
|
/remove-area localization |
@elmiko fixed it, looks good now |
graz-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small nits.
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael McCune <msm@opbstudios.com> Co-authored-by: Tim Bannister <193443691+lmktfy@users.noreply.github.com> Co-authored-by: Graziano Casto <graziano.casto@outlook.com>
94970f9 to
b98dc1e
Compare
Serenity611
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General proofreading / review against style guide looks great! Suggested one small correction to spelling / punctuation :)
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Susan Sica <90214772+Serenity611@users.noreply.github.com>
|
@graz-dev How do we move forward here? Is anything missing for an approve? |
|
@lukasmetzner how did the pairing with @dom4ha go - see #52973 (comment) If you haven't heard at all, try getting in touch once more, and then if you are on Kubernetes' Slack workspace, let the |
graz-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits, @lukasmetzner after fixing them I'm happy to merge it as a draft.
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2025-10-27-watch-based-route-reconciliation-in-ccm.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Graziano Casto <graziano.casto@outlook.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: graz-dev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: f7a962e94880738a0530bf2303e0826c017c04d9 |
@lmktfy There was not much pairing. The PR I should review was basically empty and closed after a while. I did not get any feedback. My PR was already reviewed at this time, so it was probably fine anyway. |
Description
The implementation of KEP 5237 contains a new feature gate. This feature blog shall inform users of cloud controller manager implementations that this feature gate exists and how to enable it.