Skip to content

Conversation

@lukasmetzner
Copy link
Contributor

Description

The implementation of KEP 5237 contains a new feature gate. This feature blog shall inform users of cloud controller manager implementations that this feature gate exists and how to enable it.

@k8s-ci-robot k8s-ci-robot added this to the 1.35 milestone Oct 27, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 27, 2025
@netlify
Copy link

netlify bot commented Oct 27, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 70e0315
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/68ff69f5014a870008856967

@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Oct 27, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2025
@lukasmetzner
Copy link
Contributor Author

lukasmetzner commented Oct 27, 2025

I have added the skeleton and provided some draft content to give an overall impression of the size of the feature blog.

cc @elmiko @cheftako

@netlify
Copy link

netlify bot commented Oct 27, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8bf41a7
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/693488364cbc810008e20450
😎 Deploy Preview https://deploy-preview-52973--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@graz-dev
Copy link
Contributor

Hi @lukasmetzner thank you for opening this feature blog placeholder PR.
Feature Blog PRs should be opened against the main branch, could you please fix it?

Thank you :)

@lukasmetzner lukasmetzner changed the base branch from dev-1.35 to main October 27, 2025 13:48
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2025
@lukasmetzner lukasmetzner force-pushed the blog-feature-gate-ccm-watch-based-route-controller branch from 70e0315 to feb5b0d Compare October 27, 2025 13:48
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 27, 2025
@lukasmetzner lukasmetzner force-pushed the blog-feature-gate-ccm-watch-based-route-controller branch from feb5b0d to 05faef6 Compare October 27, 2025 13:50
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2025
@elmiko
Copy link
Contributor

elmiko commented Oct 27, 2025

thanks @lukasmetzner !

@lukasmetzner lukasmetzner marked this pull request as ready for review November 3, 2025 11:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2025
@lukasmetzner
Copy link
Contributor Author

lukasmetzner commented Nov 3, 2025

The implementation is not merged yet. I would put it to hold, correct me if I am wrong here 😅 Content-wise it would be ready for a review from my side ^^

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2025
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is straightfoward and to the point. i have a couple suggestions for the intro paragraph, and a couple minor nits.

@elmiko
Copy link
Contributor

elmiko commented Nov 21, 2025

actually, i just noticed the commits. @lukasmetzner can we squash this to a single commit please.

/unlgtm

@lukasmetzner lukasmetzner force-pushed the blog-feature-gate-ccm-watch-based-route-controller branch from efb50a2 to 5690a66 Compare November 21, 2025 15:08
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/ko Issues or PRs related to Korean language labels Nov 21, 2025
@lukasmetzner lukasmetzner force-pushed the blog-feature-gate-ccm-watch-based-route-controller branch from 5690a66 to be4d4f0 Compare November 21, 2025 15:10
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2025
@k8s-ci-robot k8s-ci-robot requested a review from elmiko November 21, 2025 15:10
@lukasmetzner
Copy link
Contributor Author

/remove-area localization
/remove-language ko

@k8s-ci-robot k8s-ci-robot removed area/localization General issues or PRs related to localization language/ko Issues or PRs related to Korean language labels Nov 21, 2025
@lukasmetzner
Copy link
Contributor Author

lukasmetzner commented Nov 21, 2025

actually, i just noticed the commits. @lukasmetzner can we squash this to a single commit please.

/unlgtm

@elmiko fixed it, looks good now

Copy link
Contributor

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small nits.

Co-authored-by: Michael McCune <msm@opbstudios.com>
Co-authored-by: Tim Bannister <193443691+lmktfy@users.noreply.github.com>
Co-authored-by: Graziano Casto <graziano.casto@outlook.com>
@lukasmetzner lukasmetzner force-pushed the blog-feature-gate-ccm-watch-based-route-controller branch from 94970f9 to b98dc1e Compare November 24, 2025 06:43
Copy link
Contributor

@Serenity611 Serenity611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General proofreading / review against style guide looks great! Suggested one small correction to spelling / punctuation :)

Co-authored-by: Susan Sica <90214772+Serenity611@users.noreply.github.com>
@lukasmetzner
Copy link
Contributor Author

@graz-dev How do we move forward here? Is anything missing for an approve?

@lmktfy
Copy link
Member

lmktfy commented Dec 5, 2025

@lukasmetzner how did the pairing with @dom4ha go - see #52973 (comment)

If you haven't heard at all, try getting in touch once more, and then if you are on Kubernetes' Slack workspace, let the #release-comms folk know. They may well be able to help.

Copy link
Contributor

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits, @lukasmetzner after fixing them I'm happy to merge it as a draft.

Co-authored-by: Graziano Casto <graziano.casto@outlook.com>
@lukasmetzner lukasmetzner requested a review from graz-dev December 6, 2025 19:47
@graz-dev
Copy link
Contributor

graz-dev commented Dec 6, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: graz-dev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: f7a962e94880738a0530bf2303e0826c017c04d9

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 73e6c20 into kubernetes:main Dec 6, 2025
6 checks passed
@lukasmetzner
Copy link
Contributor Author

lukasmetzner commented Dec 15, 2025

@lukasmetzner how did the pairing with @dom4ha go - see #52973 (comment)

If you haven't heard at all, try getting in touch once more, and then if you are on Kubernetes' Slack workspace, let the #release-comms folk know. They may well be able to help.

@lmktfy There was not much pairing. The PR I should review was basically empty and closed after a while. I did not get any feedback. My PR was already reviewed at this time, so it was probably fine anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants