Skip to content

PSA host field docs #51498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

PSA host field docs #51498

merged 1 commit into from
Aug 6, 2025

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented Jul 3, 2025 •
edited
Loading

Description

Notify users that .host field in probes and lifecycle handlers can be blocked using PSA

Issue

Closes: kubernetes/kubernetes#99425
Enhancement Issue: kubernetes/enhancements#4940
Implementation PR: kubernetes/kubernetes#125271

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jul 3, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2025
@netlify Netlify
Copy link

netlify bot commented Jul 3, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5827f58
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/6893589d191aa8000821c87c

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language language/pt Issues or PRs related to Portuguese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2025
@tssurya tssurya force-pushed the psa-host-field-docs branch from 0ea1233 to 5e1715e Compare July 3, 2025 11:07
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2025
This was referenced Jul 3, 2025
Merged
Closed
@netlify Netlify
Copy link

netlify bot commented Jul 3, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5827f58
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6893589ddff92f0008b19114
😎 Deploy Preview https://deploy-preview-51498--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

lmktfy
lmktfy reviewed Jul 3, 2025
View reviewed changes
@lmktfy
Copy link
Contributor

lmktfy commented Jul 4, 2025

/sig auth
/sig security

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/security Categorizes an issue or PR as relevant to SIG Security. labels Jul 4, 2025
@enj enj added this to SIG Auth Jul 7, 2025
@enj enj moved this to Needs Triage in SIG Auth Jul 7, 2025
@tssurya
Copy link
Contributor Author

tssurya commented Jul 29, 2025

undrafting this since the code has merged.. I'll work on getting this ready asap

@tssurya tssurya marked this pull request as ready for review July 29, 2025 06:48
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2025
@k8s-ci-robot k8s-ci-robot requested review from tallclair and tengqm July 29, 2025 06:48
@k8s-ci-robot k8s-ci-robot removed language/ja Issues or PRs related to Japanese language language/pt Issues or PRs related to Portuguese language area/localization General issues or PRs related to localization area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes labels Jul 30, 2025
@tssurya
Copy link
Contributor Author

tssurya commented Jul 31, 2025

Screenshot from 2025-07-31 13-30-13 I think deployment looks OK? this PR should be good for reviews..

@michellengnx
Copy link
Contributor

Hello @tssurya 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@tssurya
Copy link
Contributor Author

tssurya commented Aug 3, 2025 •
edited
Loading

Hi @michellengnx ! I'm waiting for reviews - so I'm not sure how to get them on time? I'll ping sig-auth.

@tssurya
Copy link
Contributor Author

tssurya commented Aug 3, 2025

@liggitt perhaps you could take a peek if you have some time?

liggitt
liggitt reviewed Aug 4, 2025
View reviewed changes
@tssurya tssurya force-pushed the psa-host-field-docs branch from 3ce1a8f to 5db0e74 Compare August 6, 2025 05:33
@tssurya
Copy link
Contributor Author

tssurya commented Aug 6, 2025

Have addressed @liggitt 's comments (sorry for the delay, I should have paid closer attention to upstream release deadlines)

@liggitt
Copy link
Member

liggitt commented Aug 6, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2ec77723142f4666a76e1bf35bfc83030a84ed33

@natalisucks
Copy link
Contributor

@tssurya hey there, i'm the SIG Docs PR wrangler this week and i'm happy to help makes sure this makes the Docs Freeze. given @liggitt is happy to re-LGTM once you've committed his suggestion, can you please update this PR? I can also add both labels if needed – thanks!

@tssurya
Add docs for blocking host field using PSA
5827f58 
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
@tssurya tssurya force-pushed the psa-host-field-docs branch from 5db0e74 to 5827f58 Compare August 6, 2025 13:28
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot requested a review from liggitt August 6, 2025 13:29
@tssurya
Copy link
Contributor Author

tssurya commented Aug 6, 2025

@tssurya hey there, i'm the SIG Docs PR wrangler this week and i'm happy to help makes sure this makes the Docs Freeze. given @liggitt is happy to re-LGTM once you've committed his suggestion, can you please update this PR? I can also add both labels if needed – thanks!

done! thank you @natalisucks

@natalisucks
Copy link
Contributor

thanks @tssurya!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f333659d85e5c22fb8a4b0ea81e43cfd015ca18d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8aca96e into kubernetes:dev-1.34 Aug 6, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Closed / Done in SIG Auth Aug 6, 2025
@tssurya tssurya mentioned this pull request Aug 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmktfy lmktfy lmktfy left review comments

@b1gb4by b1gb4by Awaiting requested review from b1gb4by

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@tallclair tallclair Awaiting requested review from tallclair

@tengqm tengqm Awaiting requested review from tengqm

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@natalisucks natalisucks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/security Categorizes an issue or PR as relevant to SIG Security. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
1.34
Development

Successfully merging this pull request may close these issues.
7 participants
@tssurya @lmktfy @t-inu @michellengnx @liggitt @k8s-ci-robot @natalisucks