fix(scripts/lsync): fix show diff output if changes exist#51493
Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom Jul 3, 2025
Merged
fix(scripts/lsync): fix show diff output if changes exist#51493k8s-ci-robot merged 1 commit intokubernetes:mainfrom
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
windsonsea
reviewed
Jul 3, 2025
Member
windsonsea
left a comment
windsonsea
left a comment
There was a problem hiding this comment.
Thanks. The test result looks good.
/lgtm
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: fa5bb750c2176227262cbdaac4f5cb3557417192 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue of git diff output assigned to diff_output not displaying automatically. Previously required explicit echo, now switched to printf for proper formatting.
Issue
Closes: #51489