Skip to content

Comments

feature: upgrade hugo to v0.141.0 and fix error handlin across multiple files#51469

Closed
samzong wants to merge 2 commits intokubernetes:mainfrom
samzong:fix/Resource.Err
Closed

feature: upgrade hugo to v0.141.0 and fix error handlin across multiple files#51469
samzong wants to merge 2 commits intokubernetes:mainfrom
samzong:fix/Resource.Err

Conversation

@samzong
Copy link
Member

@samzong samzong commented Jul 2, 2025

Description

Hugo v0.141.0 breaking change - removed Resource.Err field, replaced with try keyword pattern.

Issue

Closes: #51468

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from katcosgrove July 2, 2025 02:42
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from reylejano July 2, 2025 02:42
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 2, 2025
@samzong
Copy link
Member Author

samzong commented Jul 2, 2025

Oops! we use hugo 0.133 in netlify.toml...


And, are we want to upgrade? The current ver of hugo is 147. We are much worse off.

@lmktfy
Copy link
Member

lmktfy commented Jul 2, 2025

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Jul 2, 2025
@lmktfy
Copy link
Member

lmktfy commented Jul 2, 2025

If we want to make this change, we must also edit netlify.toml to switch to a newer version of Hugo.

@lmktfy
Copy link
Member

lmktfy commented Jul 2, 2025

(aside: would this be a feature and therefore not a refactor?)

@samzong samzong changed the title refactor: update error handling for CVE data retrieval across multiple files fix: update error handling for CVE data retrieval across multiple files Jul 3, 2025
@samzong samzong changed the title fix: update error handling for CVE data retrieval across multiple files feature: upgrade hugo to v0.147.0 and fix error handlin across multiple files Jul 3, 2025
@samzong
Copy link
Member Author

samzong commented Jul 3, 2025

(aside: would this be a feature and therefore not a refactor?)

Yep, I have change the title, If we discussing about upgrade hugo version, it's should be a feature.

@netlify
Copy link

netlify bot commented Jul 3, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1f708ea
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/687581a461441b0008acbc99
😎 Deploy Preview https://deploy-preview-51469--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@samzong samzong force-pushed the fix/Resource.Err branch from 3b2e96d to 5d48020 Compare July 3, 2025 02:30
@lmktfy
Copy link
Member

lmktfy commented Jul 4, 2025

We should check that container image build and local previewing is OK, before we merge this.

@lmktfy
Copy link
Member

lmktfy commented Jul 4, 2025

We could do this in 2 steps:

  • upgrade to 0.141.x
  • upgrade to a more recent Hugo

I am wary of upgrading all the way to the latest minor release, because I / we won't have time to check all the pages that have changed.

Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong samzong force-pushed the fix/Resource.Err branch from 5d48020 to 1f708ea Compare July 14, 2025 22:16
@samzong samzong changed the title feature: upgrade hugo to v0.147.0 and fix error handlin across multiple files feature: upgrade hugo to v0.141.0 and fix error handlin across multiple files Jul 14, 2025
@samzong
Copy link
Member Author

samzong commented Jul 14, 2025

ok @lmktfy, As expected, I upgraded Hugo's version to v0.141.0, which includes new error handling methods.

@samzong
Copy link
Member Author

samzong commented Sep 21, 2025

Has not been paying attention to this PR for a long time.

@samzong samzong closed this Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot run make serve at local

3 participants