refactor(scripts): improve robustness and readability of lsync.sh#51413
Merged
lmktfy merged 1 commit intokubernetes:mainfrom Jun 30, 2025
Merged
refactor(scripts): improve robustness and readability of lsync.sh#51413lmktfy merged 1 commit intokubernetes:mainfrom
lmktfy merged 1 commit intokubernetes:mainfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Signed-off-by: samzong <samzong.lu@gmail.com>
samzong
force-pushed
the
refactor/improve-lsync-script
branch
from
88cc2ee to
50e256e
Compare
lmktfy
reviewed
Jun 30, 2025
| SYNCED=0 | ||
| fi | ||
| done | ||
| done < <(find "$1" -name "*.md" -print0) |
| # Try get the English version | ||
| EN_VERSION=`echo $LOCALIZED | sed "s/content\/.\{2,5\}\//content\/en\//g"` | ||
| if [ ! -e $EN_VERSION ]; then | ||
| EN_VERSION=$(echo "$LOCALIZED" | sed "s/content\/.\{2,5\}\//content\/en\//g") |
Member
There was a problem hiding this comment.
Suggested change
| EN_VERSION=$(echo "$LOCALIZED" | sed "s/content\/.\{2,5\}\//content\/en\//g") | |
| EN_VERSION="$(echo "$LOCALIZED" | sed "s/content\/.\{2,5\}\//content\/en\//g")" |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: f9a91f56c7c53d61a12ef3b3c1f4219e6ab418f4 |
Member
|
Let's merge. If there are snags we can revert; we can also iterate on this for further improvements. |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this PR, I refactor
scripts/lsync.shto make more robust and align shell scripting best practices.find ... -print0|while readloop.`...`) with$(...)ifwere simplified to check command exit codes, cleaner and more readable.Special: Improvements the script without changing its core functionality.