Skip to content

fixes - sidecar containers graduated to stable in 1.33 #51007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

fixes - sidecar containers graduated to stable in 1.33 #51007

merged 1 commit into from
May 22, 2025

Conversation

antechrestos
Copy link
Contributor

According to documentation, sidecar containers is now stable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @antechrestos!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 22, 2025
@netlify Netlify
Copy link

netlify bot commented May 22, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2ec6de8
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/682f43704c48810008e9f454
😎 Deploy Preview https://deploy-preview-51007--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@antechrestos antechrestos force-pushed the fixes/sidecar-containers branch from dbbe9c9 to 2ec6de8 Compare May 22, 2025 15:31
@jayeshmahajan
Copy link
Contributor

lgtm
Screen Shot 2025-05-22 at 12 24 34 PM

@salaxander
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayeshmahajan, salaxander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2025
@lmktfy
Copy link
Contributor

lmktfy commented May 22, 2025

@kubernetes/sig-node-pr-reviews please LGTM this unless incorrect

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 22, 2025
@lmktfy
Copy link
Contributor

lmktfy commented May 22, 2025

Actually I can just do that
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1deae35d9251e1390fa37fd39dcffe9bf755f45a

@k8s-ci-robot k8s-ci-robot merged commit fbf85e5 into kubernetes:main May 22, 2025
6 checks passed
@antechrestos antechrestos deleted the fixes/sidecar-containers branch May 23, 2025 06:40
@jayeshmahajan jayeshmahajan mentioned this pull request May 27, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@jayeshmahajan jayeshmahajan jayeshmahajan approved these changes

@lmktfy lmktfy Awaiting requested review from lmktfy

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@lmktfy lmktfy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@antechrestos @k8s-ci-robot @jayeshmahajan @salaxander @lmktfy @dipesh-rawat