Update scratch.md #5081
Merged
Update scratch.md #5081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This document is very good, but it does not mention anywhere how a node would obtain its own Pod CIDR when setting up static pod routing on something like bare metal. I also think the kube-proxy section on this page should include *--cluster-cidr* in the "arguments to consider" area. I say should because I'm not confident that I'm right. If I omitted --cluster-cidr from the kube-proxy and controller manager, and found that my pod routing didn't work, adding the switch would be one of the first things I'd try.
k8s-ci-robot
added
the
cncf-cla: yes
|
Deploy preview ready! Built with commit f5fe9f4 https://deploy-preview-5081--kubernetes-io-master-staging.netlify.com |
|
@erictune 👋 Pinging for review. |
|
@erictune We'd love a review, please! |
xiangpengzhao
added
the
size/XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document is very good, but it does not mention anywhere specifically how a node would obtain its own Pod CIDR when setting up static pod routing on something like bare metal.
I also think the kube-proxy section on this page should include --cluster-cidr in the "arguments to consider" area. I say should because I'm not confident that I'm right. If I omitted --cluster-cidr from the kube-proxy and controller manager, and found that my pod routing didn't work, adding the switch would be one of the first things I'd try.
This change is