-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Ensure to add v1.33 prefix for title #50666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure to add v1.33 prefix for title #50666
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Looking at other blogs, I see most of the old blogs have the slug with |
|
/sig release |
|
/lgtm |
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
/lgtm cancel
| title: "Continuing the transition from Endpoints to EndpointSlices" | ||
| slug: endpoints-deprecation | ||
| title: "Kubernetes v1.33: Continuing the transition from Endpoints to EndpointSlices" | ||
| slug: kubernetes-1-33-endpoints-deprecation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't change blog article slugs after publication. That can make for a poor UX.
| title: "Kubernetes v1.33: User Namespaces enabled by default!" | ||
| date: 2025-04-25T10:30:00-08:00 | ||
| slug: userns-enabled-by-default | ||
| slug: kubernetes-1-33-userns-enabled-by-default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't change blog article slugs after publication. That can make for a poor UX.
|
@rytswd it's OK to change article titles after publication (we still try to avoid it), but we almost never change:
This is because if we do that, it can make the changed article appear new to people using feed readers, and we have a lot of people we try not to annoy if we did do that. |
|
@lmktfy That's fair, and I will be affected by that myself 🫠 Although I personally wouldn't mind if the changes are only for few articles, I can understand this can be annoying. I will not update the old slugs to keep them untouched. However, I do think the title should be updated for consistency. Because this shouldn't affect those external readers, and this would affect only few at this point, I'd like to still push for the title prefix update. It's better UX when all the Feature Blogs are clearly aligned from the blog title IMO. (This should have been caught earlier, and I will be making sure to update the handbook accordingly.) |
679ed89 to
85b8b9f
Compare
85b8b9f to
9ec1aea
Compare
|
@lmktfy do we have the rules you've noted about not changing article slugs and blog publication date/times in our style guide or blog review guidelines? i've had a quick review now to check and may have missed it, thanks in advance. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: d2e05bc90db3078f44d0187aab006ece346528ae
|
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to change it
/hold cancel
This seems to be the convention we used to use for the previous cycles. I will document in the handbook about how the future Feature Blogs should be created with correct front matter to begin with (including
draft: true)