Skip to content

Conversation

@rytswd
Copy link
Member

@rytswd rytswd commented Apr 25, 2025

This seems to be the convention we used to use for the previous cycles. I will document in the handbook about how the future Feature Blogs should be created with correct front matter to begin with (including draft: true)

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2025
@netlify
Copy link

netlify bot commented Apr 25, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ec1aea
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/680edfe250488200080cfccd
😎 Deploy Preview https://deploy-preview-50666--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rytswd
Copy link
Member Author

rytswd commented Apr 25, 2025

Looking at other blogs, I see most of the old blogs have the slug with kubernetes-1-XX form, except for the mid cycle and release announcement, which have kubernetes-v1-XX. To keep it consistent throughout, it may be better to always use "v" prefix everywhere? (Although this wouldn't be the case for old blogs, it would be simpler to explain for future blogs)

CC @natalisucks @lmktfy

@rytswd
Copy link
Member Author

rytswd commented Apr 25, 2025

/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Apr 25, 2025
@natalisucks
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025
Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

/lgtm cancel

title: "Continuing the transition from Endpoints to EndpointSlices"
slug: endpoints-deprecation
title: "Kubernetes v1.33: Continuing the transition from Endpoints to EndpointSlices"
slug: kubernetes-1-33-endpoints-deprecation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't change blog article slugs after publication. That can make for a poor UX.

title: "Kubernetes v1.33: User Namespaces enabled by default!"
date: 2025-04-25T10:30:00-08:00
slug: userns-enabled-by-default
slug: kubernetes-1-33-userns-enabled-by-default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't change blog article slugs after publication. That can make for a poor UX.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2025
@lmktfy
Copy link
Member

lmktfy commented Apr 27, 2025

@rytswd it's OK to change article titles after publication (we still try to avoid it), but we almost never change:

  • article publication date / time
  • article slug

This is because if we do that, it can make the changed article appear new to people using feed readers, and we have a lot of people we try not to annoy if we did do that.

@rytswd
Copy link
Member Author

rytswd commented Apr 28, 2025

@lmktfy That's fair, and I will be affected by that myself 🫠 Although I personally wouldn't mind if the changes are only for few articles, I can understand this can be annoying. I will not update the old slugs to keep them untouched.

However, I do think the title should be updated for consistency. Because this shouldn't affect those external readers, and this would affect only few at this point, I'd like to still push for the title prefix update. It's better UX when all the Feature Blogs are clearly aligned from the blog title IMO.

(This should have been caught earlier, and I will be making sure to update the handbook accordingly.)

@rytswd rytswd force-pushed the update-slug-and-blog-title-with-v1.33-prefix branch from 679ed89 to 85b8b9f Compare April 28, 2025 01:54
@rytswd rytswd force-pushed the update-slug-and-blog-title-with-v1.33-prefix branch from 85b8b9f to 9ec1aea Compare April 28, 2025 01:54
@rytswd rytswd changed the title Ensure to add v1.33 prefix for title and slug Ensure to add v1.33 prefix for title Apr 28, 2025
@natalisucks
Copy link
Contributor

@lmktfy do we have the rules you've noted about not changing article slugs and blog publication date/times in our style guide or blog review guidelines? i've had a quick review now to check and may have missed it, thanks in advance.

@reylejano
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d2e05bc90db3078f44d0187aab006ece346528ae

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to change it
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit 940ee50 into kubernetes:main May 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants