Skip to content

Add more clarity for horizontal-pod-autoscaler-cpu-initialization-period #50558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

Add more clarity for horizontal-pod-autoscaler-cpu-initialization-period #50558

merged 1 commit into from
May 26, 2025

Conversation

jayeshmahajan
Copy link
Contributor

Description

Clarify HPA readiness and CPU initialization behavior

This PR enhances the documentation for the HorizontalPodAutoscaler by clarifying the role of --horizontal-pod-autoscaler-cpu-initialization-period and --horizontal-pod-autoscaler-initial-readiness-delay. It provides guidance for Pods with high CPU usage during startup and recommends best practices for readiness probe configuration to avoid premature scaling.

Issue

#12657

Closes: #12657

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 19, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 19, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b1af125
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/68083882ae97750008ba7647
😎 Deploy Preview https://deploy-preview-50558--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jayeshmahajan
Copy link
Contributor Author

https://deploy-preview-50558--kubernetes-io-main-staging.netlify.app/docs/tasks/run-application/horizontal-pod-autoscale/#understanding-pod-readiness-timing-in-hpa

lmktfy
lmktfy reviewed Apr 20, 2025
View reviewed changes
Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Ideally we don't use section numbers in headings; see inline suggestions. It's good to document Kubernetes behaviour so thank you for spotting the gap here and sending in a proposed fix.

@jayeshmahajan
Update horizontal-pod-autoscale.md with horizontal-pod-autoscaler-cpu…
b1af125 
…-initialization-period

Adding more xf by decoding the issue discussion and implementation kubernetes#12657

Update horizontal-pod-autoscale.md

Update horizontal-pod-autoscale.md
@jayeshmahajan jayeshmahajan requested a review from lmktfy April 23, 2025 00:47
@jayeshmahajan
Copy link
Contributor Author

jayeshmahajan commented Apr 23, 2025 •
edited
Loading

Thank you

Ideally we don't use section numbers in headings; see inline suggestions. It's good to document Kubernetes behaviour so thank you for spotting the gap here and sending in a proposed fix.

Thank you @lmktfy. Made the required changes and squashed it.

@jayeshmahajan
Copy link
Contributor Author

When you get a chance, could you please take a look and let me know if anything needs to be updated? @lmktfy @dipesh-rawat @DirectXMan12

@katcosgrove
Copy link
Contributor

/lgtm

/assign @divya-mohan0209

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cf5fb2e3d63666173f7b65314a38d8744e23bbd5

@lmktfy
Copy link
Contributor

lmktfy commented May 26, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 05db117 into kubernetes:main May 26, 2025
6 checks passed
@jayeshmahajan jayeshmahajan deleted the patch-6 branch May 26, 2025 21:40
@jayeshmahajan jayeshmahajan mentioned this pull request May 27, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@lmktfy lmktfy Awaiting requested review from lmktfy

Assignees

@divya-mohan0209 divya-mohan0209

@katcosgrove katcosgrove

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear definition of the --horizontal-pod-autoscaler-initial-readiness-delay flag
5 participants
@jayeshmahajan @katcosgrove @k8s-ci-robot @lmktfy @divya-mohan0209