-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update image used for image volume task #50158
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @saschagrunert |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
We probably have to incorporate that into #49936 |
@@ -13,5 +13,5 @@ spec: | |||
volumes: | |||
- name: volume | |||
image: | |||
reference: quay.io/crio/artifact:v1 | |||
reference: alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reference: alpine | |
reference: docker.io/library/alpine:3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we pick an image that isn't executable the way a traditional container would be.
Testing this PR locally on Killercoda has been difficult. This part in the documentation isn't clear. - The container runtime needs to support the image volumes feature
- You need to exec commands in the host
- You need to be able to exec into pods
- You need to enable the `ImageVolume` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) Which container runtime supports it? I am using |
You may not be able to use Killercoda to test this alpha feature @network-charles |
Alright We may need to remove this line, it says we can test it on Killercoda.
|
I don't think https://kubernetes.io/docs/tasks/configure-pod-container/image-volumes/#before-you-begin is outright wrong. In a separate PR, we could clarify that the playgrounds (that are external) may not support all alpha / beta features. This PR is about changing the example volume. |
Alright Since it's a minor fix, it’d be great if @nojnhuh would resolve it here rather than opening a new PR. |
(writing as an approver for English) |
Alright, I will. Can you tell me how to test the example locally? |
Maybe we could add a hint like this to the page! Anyway, try: minikube start --feature-gates=ImageVolume=true @network-charles this is the wrong change though so as things stand it is not useful to put in a lot of effort to test it. |
Sorry, what do you mean by “this is the wrong change”? |
The image @nojnhuh is suggesting isn't a good example of an image to use as an image volume, because it's an executable image. |
My main motivation for this PR was to modify the example to also work with containerd, and that runtime doesn't support mounting non-executable OCI artifacts yet: containerd/containerd#11381 I understand mounting a "regular" container image is the less interesting use case, but that happens to be the lowest common denominator among what works with both CRI-O and containerd at the moment AFAIK. |
Hi @sftim, the Alpine image (docker.io/library/alpine:3) you suggested didn't work for me on my minikube cluster. kubectl get pod
NAME READY STATUS RESTARTS AGE
image-volume 0/1 CreateContainerError 0 5m41s |
Description
This PR resolves issues I ran into following Use an Image Volume With a Pod with containerd:
kubectl attach
command was invalid. I updated it to usekubectl exec
instead.Issue
Closes: #