Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link to GitHub @kubernetes/release-engineering page in Release Managers docs #50150

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

khanhtc1202
Copy link
Contributor

@khanhtc1202 khanhtc1202 commented Mar 19, 2025

Description

Remove the link to GitHub @kubernetes/release-engineering page in Release Managers docs. This means to team mention (as text), should not provide link to prevent misleading.

Issue

NONE

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@k8s-ci-robot k8s-ci-robot requested a review from jrsapi March 19, 2025 11:05
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign salaxander for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2025
Copy link

netlify bot commented Mar 19, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ce6bb57
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67dbe7efc01b3c00080c5382
😎 Deploy Preview https://deploy-preview-50150--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ritikaa96
Copy link
Contributor

/lgtm
Thank you for your contribution.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a22a414a74669198e99be8900025f9b25ba70897

Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't meant to be a link, it's the tag you need to use to mention the team on GitHub. I'm not sure if we really want it to look like you need to go to the linked page to find what/who you need to mention.

@khanhtc1202
Copy link
Contributor Author

This isn't meant to be a link, it's the tag you need to use to mention the team on GitHub. I'm not sure if we really want it to look like you need to go to the linked page to find what/who you need to mention.

In such case, what does this mean in the first place ( ref: https://github.com/kubernetes/website/blob/main/content/en/releases/release-managers.md?plain=1#L88 )
I think if both are meant to be the same, they should be the same.

@stmcginnis
Copy link
Contributor

I think that other one is incorrect too. This is a team tag, so you can do a team mention to notify the members of that team. Linking to the actual team makes it look like you are expected to follow the link to get the list of the individual members of the team to tag separately, but that is not the intent.

@khanhtc1202
Copy link
Contributor Author

@stmcginnis I got your point. Then, let me update the other to make it not a link to GitHub team page.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2025
@k8s-ci-robot k8s-ci-robot requested a review from Ritikaa96 March 20, 2025 10:03
@khanhtc1202 khanhtc1202 changed the title Fix missing link to release-engineering team on GitHub Remove link to GitHub @kubernetes/release-engineering page in Release Managers docs Mar 20, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing /retitle in a comment.

When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stmcginnis
Copy link
Contributor

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 650651d9c561841843affb0732fad216bd88dd35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants