-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove link to GitHub @kubernetes/release-engineering page in Release Managers docs #50150
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/lgtm |
LGTM label has been added. Git tree hash: a22a414a74669198e99be8900025f9b25ba70897
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't meant to be a link, it's the tag you need to use to mention the team on GitHub. I'm not sure if we really want it to look like you need to go to the linked page to find what/who you need to mention.
In such case, what does this mean in the first place ( ref: https://github.com/kubernetes/website/blob/main/content/en/releases/release-managers.md?plain=1#L88 ) |
I think that other one is incorrect too. This is a team tag, so you can do a team mention to notify the members of that team. Linking to the actual team makes it look like you are expected to follow the link to get the list of the individual members of the team to tag separately, but that is not the intent. |
@stmcginnis I got your point. Then, let me update the other to make it not a link to GitHub team page. |
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request. You can edit the title by writing /retitle in a comment.
When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm Thanks! |
LGTM label has been added. Git tree hash: 650651d9c561841843affb0732fad216bd88dd35
|
Description
Remove the link to GitHub @kubernetes/release-engineering page in Release Managers docs. This means to team mention (as text), should not provide link to prevent misleading.
Issue
NONE