Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend descriptions about init containers #50105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Amend descriptions about init containers #50105

wants to merge 1 commit into from

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 15, 2025

This PR amends the ambiguous description about init containers and sidecar containers.

  • The schedulability of a Pod is determined by the maximum requests of init-containers, or the sum requests of sidecar containers and app containers, whichever is the higher one.
  • The QoS of a Pod is only determined by the requests/limits setting for application containers. Init-containers or sidecar containers won't affect the QoS tier of a Pod.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tengqm. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 15, 2025 •
edited
Loading

✅ Pull request preview available for checking

Name Link
🔨 Latest commit fc97822
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67d76d4a5a0c2800089fae9d
😎 Deploy Preview https://deploy-preview-50105--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Mar 17, 2025

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 17, 2025
sftim
sftim reviewed Mar 17, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

Let's get a technical review on this change to make sure we're explaining things right (I imagine it is, but I don't feel qualified to formally comment).

The existing docs have already been through a review process and we should make sure not to merge a regression.

content/en/docs/concepts/workloads/pods/init-containers.md Outdated
@@ -326,16 +326,15 @@ for resource usage apply:
containers is the *effective init request/limit*. If any resource has no
resource limit specified this is considered as the highest limit.
* The Pod's *effective request/limit* for a resource is the higher of:
* the sum of all app containers request/limit for a resource
* the sume request/limit for a resource for all app containers and sidecar containers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "sume" doesn't look right

@tengqm tengqm force-pushed the amend-init-containers branch from 90f6e9c to fc97822 Compare March 17, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Status: Needs Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tengqm @k8s-ci-robot @sftim