Skip to content

Add HPA 'configurable tolerance' blog post (KEP-4951). #50000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 14, 2025
Merged

Add HPA 'configurable tolerance' blog post (KEP-4951). #50000

merged 9 commits into from
Apr 14, 2025

Conversation

@jm-franc
Copy link
Contributor

@jm-franc jm-franc commented Mar 4, 2025

Description

Add a blog post describing the new alpha HPA 'configurable tolerance' feature.

Issue

This blog post documents the new KEP-4951; see
kubernetes/enhancements#4951

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2025
@jm-franc
Copy link
Contributor Author

jm-franc commented Mar 4, 2025

/assign @aibarbetta

@jm-franc jm-franc marked this pull request as ready for review March 4, 2025 16:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2025
@k8s-ci-robot k8s-ci-robot requested a review from Gauravpadam March 4, 2025 16:26
@jm-franc jm-franc mentioned this pull request Mar 4, 2025
Open
11 tasks
@netlify
Copy link

netlify bot commented Mar 4, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3408bcc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67dc2d2f946e470008cf4ea1
😎 Deploy Preview https://deploy-preview-50000--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

If you incorporate the inline feedback (see below), we'll be happy to merge it as a draft. We can then work on getting a publication date assigned.

I don't know if you'd also like to work on the docs updates, but help would be welcome if you have the capacity for it.

@jm-franc
Copy link
Contributor Author

jm-franc commented Mar 4, 2025

Thanks for the PR!
[...]
I don't know if you'd also like to work on the docs updates, but help would be welcome if you have the capacity for it.

Thank you much Tim, I've updated following your comments! I have opened a draft PR for the doc update (#49826), I'll work on this asap.

graz-dev
graz-dev reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jm-franc nice piece!
I just added a few comments to make it clearer to the reader.
Thank you :)

sftim
sftim reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tweak suggestion.

Article looks good.

@jm-franc
Replace 'feature flag' with 'feature gate'.
bccde8b 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
rytswd
rytswd reviewed Mar 18, 2025
View reviewed changes
Copy link
Member

@rytswd rytswd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the blog post, I learned something new today!
Just left a few comments / suggestions 🥰

graz-dev
graz-dev reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jm-franc I added some suggestions to align the title and slug format with other similat posts published for previous releases.
Then, in example manifest to configure the tollerance I can't see the example you mentioned in one of my previous review that clarify what happen when you use 0as value for tollerance.

@jm-franc @graz-dev
Update metadata to align with other articles
3408bcc 
Following review.

Co-authored-by: Graziano Casto <graziano.casto@outlook.com>
@graz-dev
Copy link
Contributor

graz-dev commented Mar 20, 2025 •
edited
Loading

@jm-franc yep I missed that comment sorry!

/lgtm

Edited: @sftim looks good to me but I can't use the command 🥲

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 20, 2025

@graz-dev: changing LGTM is restricted to collaborators

In response to this:

@jm-franc yep I missed that comment sorry!

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@graz-dev graz-dev mentioned this pull request Mar 21, 2025
Closed
11 tasks
@jm-franc jm-franc mentioned this pull request Mar 25, 2025
Merged
@jm-franc
Copy link
Contributor Author

jm-franc commented Mar 28, 2025

/assign @sftim

Assigning Tim for lgtm & approval.

@graz-dev
Copy link
Contributor

graz-dev commented Mar 29, 2025

@lmktfy FYI (maybe you don't receive notification for the archived account)

@jm-franc
Copy link
Contributor Author

jm-franc commented Apr 4, 2025

Friendly ping @lmktfy @sftim when you have the time to look at this.

@graz-dev
Copy link
Contributor

graz-dev commented Apr 10, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 10, 2025

LGTM label has been added.

Git tree hash: 19c048da1c2cb8c61961b645766e030e5edc0cfc

sftim
sftim reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve this to merge in as draft.

Release comms can mark this for publication on release day (and I hope they will).
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2247c6c into kubernetes:main Apr 14, 2025
6 checks passed
@rytswd rytswd mentioned this pull request Apr 22, 2025
Merged
@rytswd
Copy link
Member

rytswd commented Apr 22, 2025

I have made a PR for the publication, which is scheduled for Tuesday, 29th April, 2025
#50584

@rytswd
Copy link
Member

rytswd commented Apr 28, 2025

Due to another blog not being ready, I'm bumping up this blog to be published on Monday, 28th April, 2025 instead.
#50714

This was referenced May 22, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natalisucks natalisucks Awaiting requested review from natalisucks

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@Gauravpadam Gauravpadam Awaiting requested review from Gauravpadam

3 more reviewers

@sftim sftim sftim left review comments

@rytswd rytswd rytswd left review comments

@graz-dev graz-dev graz-dev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@aibarbetta aibarbetta

@sftim sftim

@graz-dev graz-dev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jm-franc @graz-dev @k8s-ci-robot @rytswd @sftim @aibarbetta