Specify the default batch mode for each backend type. #49809
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
language/en
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| - `batch` - buffer events and asynchronously process them in batches. This is the default. | ||
| - `blocking` - block API server responses on processing each individual event. | ||
| - `batch` - buffer events and asynchronously process them in batches. This is the default mode for `webhook` backend. | ||
| - `blocking` - block API server responses on processing each individual event. This is the default mode for `log` backend. |
There was a problem hiding this comment.
I'm not sure this is relevant to a description of the --audit-webhook-mode command line argument. I think this detail belongs elsewhere in the document @MohammadAlavi1986
There was a problem hiding this comment.
To get the same flag for log backend, replace webhook with log in the flag name
I think the documentation focuses only on the webhook backend flags for brevity, as the log backend flags are identical.
|
@MohammadAlavi1986 would you have capacity / be willing to revise this based on feedback so far? |
k8s-ci-robot
added
size/M
I added tabs to list flags specific to each backend separately. I also added --audit-*-batch-throttle-enable flag to the list of flags and specified the default value for each flag. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8d64615348974a26e2ec663ac598ed7e0ef46ac9
|
Specify the default batch mode for each backend type.
The default batch mode for
webhookbackend isbatchandblockingforlogbackend. However, the current documentation gives the impression thatbatchis the default mode for both backend types.