Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3998: Graduate JobSuccessPolicy to Stable #49807

Merged
merged 1 commit into from
Mar 27, 2025
Merged

KEP-3998: Graduate JobSuccessPolicy to Stable #49807

merged 1 commit into from
Mar 27, 2025
+4 −8

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Feb 17, 2025 •
edited
Loading

Description

Issue

I updated the documentation sicne we are promoting JobSuccessPolicy to GA in 1.33.

Part-of: #kubernetes/enhancements#3998

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 17, 2025
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 17, 2025
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 17, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5870bf3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67dd469262601a00086ecb4b

@tenzen-y tenzen-y mentioned this pull request Feb 17, 2025
Open
29 tasks
@netlify Netlify
Copy link

netlify bot commented Feb 17, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5870bf3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67dd4692837ca7000851b23d
😎 Deploy Preview https://deploy-preview-49807--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dipesh-rawat
dipesh-rawat reviewed Feb 18, 2025
View reviewed changes
go.mod Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change in the go.mod file intentional, or added by mistake?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These is not intended changes. So, I will remove this change. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

go.sum Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this file - was it meant to be included?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dipesh-rawat
Copy link
Member

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Feb 18, 2025
soltysh
soltysh suggested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're also missing removing the note section in https://kubernetes.io/docs/concepts/workloads/controllers/job/#success-policy, that's content/en/docs/concepts/workloads/controllers/job.md file. You'll want to drop that note entirely.

@tenzen-y
Copy link
Member Author

You're also missing removing the note section in https://kubernetes.io/docs/concepts/workloads/controllers/job/#success-policy, that's content/en/docs/concepts/workloads/controllers/job.md file. You'll want to drop that note entirely.

Thank you for pointing it out. After I complete all documentation changes, I will ping apps maintainers, thanks.

@tenzen-y tenzen-y force-pushed the success-policy-ga branch 2 times, most recently from 19a228d to 693e289 Compare March 21, 2025 10:47
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2025
@tenzen-y tenzen-y force-pushed the success-policy-ga branch 3 times, most recently from ec89bec to 0b727dd Compare March 21, 2025 10:55
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2025
@tenzen-y tenzen-y marked this pull request as ready for review March 21, 2025 10:56
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
@tenzen-y
KEP-3998: Graduate JobSuccessPolicy to Stable
5870bf3 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the success-policy-ga branch from 0b727dd to 5870bf3 Compare March 21, 2025 10:59
@tenzen-y
Copy link
Member Author

@dipesh-rawat @soltysh I addressed all comments. PTAL, thank you!

soltysh
soltysh approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from sig-apps pov

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 75be558ef93b166da5ce7ebd31e7f14df6dc7934

@tengqm
Copy link
Contributor

tengqm commented Mar 26, 2025

/approve
/hold
Adding a hold for the upstream k/k code merge.
Feel free to lift the hold when change is merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2025
@tenzen-y
Copy link
Member Author

/approve /hold Adding a hold for the upstream k/k code merge. Feel free to lift the hold when change is merged.

Actually, all k/k codes have already been merged.
Thank you for all!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 38f74cf into kubernetes:dev-1.33 Mar 27, 2025
6 checks passed
@tenzen-y tenzen-y deleted the success-policy-ga branch March 27, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@soltysh soltysh soltysh approved these changes

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@salaxander salaxander Awaiting requested review from salaxander

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Apps
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tenzen-y @dipesh-rawat @k8s-ci-robot @tengqm @soltysh