Skip to content

docs: add an example of a Service-scoped Pod DNS record #49601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: add an example of a Service-scoped Pod DNS record #49601

wants to merge 1 commit into from
+9 −1

Conversation

davidxia
Copy link
Contributor

This example will help the reader understand. It's also more consistent to provide an example like the preceding Pod-scoped DNS record paragraphs.

follow up to #49532

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jan 30, 2025
@k8s-ci-robot k8s-ci-robot requested review from bowei and thockin January 30, 2025 20:13
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 30, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2025
@davidxia
Copy link
Contributor Author

cc @sftim who reviewed #49532

@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c182730
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679bdd634d9e330008d1224b
😎 Deploy Preview https://deploy-preview-49601--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ffaedbf
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6831b75991ef880008e23fb4
😎 Deploy Preview https://deploy-preview-49601--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sftim
Copy link
Contributor

sftim commented Jan 31, 2025

cc @sftim who reviewed #49532

/uncc

I'm afraid I'm going to decline to review this one. Once it has LGTM, please assign to the nominated approver.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2025
jayeshmahajan
jayeshmahajan approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@jayeshmahajan jayeshmahajan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that be ending with .svc.cluster.local instead of .cluster.local ?

jayeshmahajan
jayeshmahajan suggested changes May 23, 2025
View reviewed changes
Copy link
Contributor

@jayeshmahajan jayeshmahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be .svc.cluster.local

172-17-0-3.barista.cafe.**svc**.cluster.local

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2025
@davidxia
Copy link
Contributor Author

Should be .svc.cluster.local

172-17-0-3.barista.cafe.**svc**.cluster.local

@jayeshmahajan yes, thanks! Updated. How about now?

jayeshmahajan
jayeshmahajan approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@jayeshmahajan jayeshmahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jayeshmahajan
Copy link
Contributor

Should be .svc.cluster.local
172-17-0-3.barista.cafe.**svc**.cluster.local

@jayeshmahajan yes, thanks! Updated. How about now?

Perfect, thank you!

@davidxia
Copy link
Contributor Author

@jayeshmahajan do you need to add the lgtm issue label and then assign @nate-double-u per robot's comments? 🙏

@jayeshmahajan
Copy link
Contributor

I'm still not member of Kubernetes org to do that. May be @bowei @thockin @dipesh-rawat @salaxander can do

@thockin
Copy link
Member

thockin commented May 23, 2025

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4320ce96e202c2cd5d47886deb97f717ba9fed05

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jayeshmahajan, thockin
Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

reylejano
reylejano reviewed May 24, 2025
View reviewed changes
reylejano
reylejano reviewed May 24, 2025
View reviewed changes
@davidxia
docs: add an example of a Service-scoped Pod DNS record
ffaedbf 
This example will help the reader understand. It's also more consistent to
provide an example like the preceding Pod-scoped DNS record paragraphs.

Update the other example to be consistent with the Pod DNS name's format.

Signed-off-by: David Xia <david@davidxia.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@davidxia davidxia requested a review from reylejano May 24, 2025 12:12
@davidxia
Copy link
Contributor Author

ready for another review. I think I addressed all comments so far.

@jayeshmahajan jayeshmahajan mentioned this pull request May 27, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayeshmahajan jayeshmahajan jayeshmahajan approved these changes

@bowei bowei Awaiting requested review from bowei

@thockin thockin Awaiting requested review from thockin

@reylejano reylejano Awaiting requested review from reylejano

Assignees

@thockin thockin

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@davidxia @sftim @k8s-triage-robot @jayeshmahajan @thockin @k8s-ci-robot @reylejano