-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Bump Docsy to 0.7.x #48725
base: main
Are you sure you want to change the base?
[WIP] Bump Docsy to 0.7.x #48725
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the deploy preview (here), I noticed that the search query text in the navbar input box is currently invisible due to the text color being white.
Ah, this needs a fix! |
38c2fe6
to
2f60fd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 3dbdac5eb865ca0edc576155cff3809885318103
|
2f60fd0
to
b6ea0af
Compare
New changes are detected. LGTM label has been removed. |
21a0c9b
to
32d38fd
Compare
This also needs more work on working well for mobile / narrow viewports. /retitle [WIP] Bump Docsy to 0.7.x See #48724 for a PR that may be better to merge. |
Hmm, I think this needs a new approach. I hope to get time to revisit it. |
@sftim: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
32d38fd
to
b84a9b5
Compare
b84a9b5
to
aa7ca6f
Compare
aa7ca6f
to
7815918
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
// Kubernetes logo starts off with white text | ||
.navbar-logo #kubernetes-logo-text { | ||
fill: $white; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is using CSS to style the text within the SVG logo.
7815918
to
285ac08
Compare
This PR upgrades to a newer version of Docsy: 0.7.2 (preview)
In the testing I've done, I haven't found any different look or behavior that still needs fixing.On narrow viewports, the site doesn't adapt right (it's still thinking in terms of older Bootstrap). And the top nav doesn't look right.Relevant to issue #44002
/area web-development
This PR incorporates the commits from PRs: