Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bump Docsy to 0.7.x #48725

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Nov 14, 2024

This PR upgrades to a newer version of Docsy: 0.7.2 (preview)

In the testing I've done, I haven't found any different look or behavior that still needs fixing. On narrow viewports, the site doesn't adapt right (it's still thinking in terms of older Bootstrap). And the top nav doesn't look right.

Relevant to issue #44002

/area web-development

This PR incorporates the commits from PRs:

@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 14, 2024
Copy link

netlify bot commented Nov 14, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 285ac08
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679c15ccbbc3610008f94ffa
😎 Deploy Preview https://deploy-preview-48725--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the deploy preview (here), I noticed that the search query text in the navbar input box is currently invisible due to the text color being white.

@sftim sftim marked this pull request as draft November 15, 2024 11:10
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2024
@sftim
Copy link
Contributor Author

sftim commented Nov 15, 2024

Ah, this needs a fix!

@sftim sftim force-pushed the 20241102_docsy_zero_seven branch 2 times, most recently from 38c2fe6 to 2f60fd0 Compare November 16, 2024 11:53
@sftim sftim marked this pull request as ready for review November 16, 2024 11:54
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2024
package.json Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2024
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3dbdac5eb865ca0edc576155cff3809885318103

@sftim sftim force-pushed the 20241102_docsy_zero_seven branch from 2f60fd0 to b6ea0af Compare November 18, 2024 14:18
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2024
@k8s-ci-robot k8s-ci-robot requested a review from Arhell November 18, 2024 14:18
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2024
@sftim sftim force-pushed the 20241102_docsy_zero_seven branch from 21a0c9b to 32d38fd Compare November 18, 2024 20:37
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2024
@sftim
Copy link
Contributor Author

sftim commented Nov 19, 2024

This also needs more work on working well for mobile / narrow viewports.

/retitle [WIP] Bump Docsy to 0.7.x

See #48724 for a PR that may be better to merge.

@k8s-ci-robot k8s-ci-robot changed the title Bump Docsy to 0.7.x [WIP] Bump Docsy to 0.7.x Nov 19, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
@sftim
Copy link
Contributor Author

sftim commented Nov 20, 2024

Hmm, I think this needs a new approach.
/close

I hope to get time to revisit it.

@k8s-ci-robot
Copy link
Contributor

@sftim: Closed this PR.

In response to this:

Hmm, I think this needs a new approach.
/close

I hope to get time to revisit it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2024
@sftim sftim reopened this Dec 31, 2024
@sftim sftim force-pushed the 20241102_docsy_zero_seven branch from 32d38fd to b84a9b5 Compare December 31, 2024 07:29
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 31, 2024
@sftim sftim force-pushed the 20241102_docsy_zero_seven branch from b84a9b5 to aa7ca6f Compare December 31, 2024 07:45
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 31, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2025
@sftim sftim force-pushed the 20241102_docsy_zero_seven branch from aa7ca6f to 7815918 Compare January 14, 2025 21:39
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment on lines +206 to +238
// Kubernetes logo starts off with white text
.navbar-logo #kubernetes-logo-text {
fill: $white;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is using CSS to style the text within the SVG logo.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2025
@sftim sftim force-pushed the 20241102_docsy_zero_seven branch from 7815918 to 285ac08 Compare January 31, 2025 00:14
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants