Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Button Text Not Displayed in Selected Language for "Tell Your Story" Button in Case Study Tab #48671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ayushontop
Copy link

Bug : When switching to a different language on the website, most text updates correctly. However, the text on the "Tell Your Story" button in the Case Study tab does not switch to the selected language. This issue may confuse users who speak only the selected language, potentially leading to missed feedback.

Fix: This PR ensures that the "Tell Your Story" button in the Case Study tab correctly displays the text in the selected language, providing a consistent experience for users in any language.

Closes: #37501

Copy link

linux-foundation-easycla bot commented Nov 9, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ayushontop / name: Ayush Tiwari (7c894a2)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 9, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ayushontop!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 9, 2024
@ayushontop
Copy link
Author

Hello @divya-mohan0209 and @sftim,

I'm excited to submit my first PR here! Please let me know if any changes are needed or if further adjustments should be made. Also, I’ve signed the CLA.

Looking forward to your feedback!

Copy link

netlify bot commented Nov 9, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7c894a2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/673191642c4a070008b8e140
😎 Deploy Preview https://deploy-preview-48671--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gauravpadam
Copy link
Member

/easycla

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hi] Wrong language for “Tell your story” button on Case Studies page.
4 participants