-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: shortcode formatting and typo(s) #48622
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
content/en/docs/tutorials/services/pods-and-endpoint-termination-flow.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Arvind <aruparekh@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about misunderstanding the change before. To make this easiest to review, please split this PR into two:
- one PR that changes the shortcode only
- one PR that only fixes English content
/hold
pending that split
OK to unhold if the PR is now a single commit that only includes one of the above changes.
@Thoughtscript if you're not sure about how to do that split, we're happy to explain further.
Description
Some small changes to documentation to get familiar with CI/CD, tooling, etc.
Thanks!
Issue
Some nitpicks/fairly trivial typos fixed.
Per API style/conventions guide #26190 - Shortcode command looks like it should be background highlighted but isn't wrapped by a
p
tag.Screenshot:
Should be:
Think the include and shortcode gets used in all of the language translations.
Reviewers: you can see an example of the change on this page
/docs/tasks/inject-data-application/define-command-argument-container/
Closes: #48621