-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add advice about checking package repository source (RPM) #48608
base: main
Are you sure you want to change the base?
Conversation
Welcome @rotimislaw! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having this note seems ok. made one suggestion.
/sig cluster-lifecycle
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lubomir I. Ivanov <neolit123@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/tide merge-method-squash
/lgtm
/assign @nate-double-u
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md
Outdated
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: e944e0a398c9022ae904f071692b5961edaadba7
|
/retitle Add advice about checking package repository source (RPM) |
@@ -113,6 +113,8 @@ sudo yum list --showduplicates kubeadm --disableexcludes=kubernetes | |||
{{% /tab %}} | |||
{{< /tabs >}} | |||
|
|||
If you don't see the version you expect to upgrade to, [verify if the Kubernetes package repositories are used.](/docs/tasks/administer-cluster/kubeadm/change-package-repository/#verifying-if-the-kubernetes-package-repositories-are-used) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest we put this a little bit earlier in this page, something like the following
as a precondition to check.
If you don't see the version you expect to upgrade to, [verify if the Kubernetes package repositories are used.](/docs/tasks/administer-cluster/kubeadm/change-package-repository/#verifying-if-the-kubernetes-package-repositories-are-used) | |
Please make sure you are using [the Kubernetes package repositories](/docs/tasks/administer-cluster/kubeadm/change-package-repository/#verifying-if-the-kubernetes-package-repositories-are-used) | |
when upgrading a cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your input @tengqm ! The case is there's a similar reference to what you say just above the section where I want to include this comment. I was wondering if it won't be better to just rephrase that one, because for me (quite newby in Kubernetes) it wasn't straightforward connection I should change the package repository to be able to download other Kubernetes version. Thus I believe it's important to include the 'version' keyword in this context, nonetheless of where it would be
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My take was that if you are not using the official package repository, you may encounter problems other than versions missing. I was suggesting to make this as early as possible in this page, and to avoid restricting the problem to the version issue.
Description
I spent lots of time trying to upgrade my Kubernetes cluster and re-reading the official doc only to realise the information I was missing wasn't referenced in the main kubeadm upgrade document, but one of the subsequent pages. I believe simple reference in correct place will facilitate upgrade process for many people doing this from now on
Issue
N/A