Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advice about checking package repository source (RPM) #48608

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rotimislaw
Copy link

Description

I spent lots of time trying to upgrade my Kubernetes cluster and re-reading the official doc only to realise the information I was missing wasn't referenced in the main kubeadm upgrade document, but one of the subsequent pages. I believe simple reference in correct place will facilitate upgrade process for many people doing this from now on

Issue

N/A

Copy link

linux-foundation-easycla bot commented Oct 31, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 31, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @rotimislaw!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 31, 2024
Copy link

netlify bot commented Oct 31, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 73a4126
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67239bbba7c9270008d51e99
😎 Deploy Preview https://deploy-preview-48608--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having this note seems ok. made one suggestion.

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Oct 31, 2024
Co-authored-by: Lubomir I. Ivanov <neolit123@gmail.com>
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/tide merge-method-squash
/lgtm
/assign @nate-double-u

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nate-double-u. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e944e0a398c9022ae904f071692b5961edaadba7

@sftim
Copy link
Contributor

sftim commented Oct 31, 2024

/retitle Add advice about checking package repository source (RPM)

@k8s-ci-robot k8s-ci-robot changed the title Update kubeadm-upgrade.md Add advice about checking package repository source (RPM) Oct 31, 2024
@@ -113,6 +113,8 @@ sudo yum list --showduplicates kubeadm --disableexcludes=kubernetes
{{% /tab %}}
{{< /tabs >}}

If you don't see the version you expect to upgrade to, [verify if the Kubernetes package repositories are used.](/docs/tasks/administer-cluster/kubeadm/change-package-repository/#verifying-if-the-kubernetes-package-repositories-are-used)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest we put this a little bit earlier in this page, something like the following
as a precondition to check.

Suggested change
If you don't see the version you expect to upgrade to, [verify if the Kubernetes package repositories are used.](/docs/tasks/administer-cluster/kubeadm/change-package-repository/#verifying-if-the-kubernetes-package-repositories-are-used)
Please make sure you are using [the Kubernetes package repositories](/docs/tasks/administer-cluster/kubeadm/change-package-repository/#verifying-if-the-kubernetes-package-repositories-are-used)
when upgrading a cluster.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your input @tengqm ! The case is there's a similar reference to what you say just above the section where I want to include this comment. I was wondering if it won't be better to just rephrase that one, because for me (quite newby in Kubernetes) it wasn't straightforward connection I should change the package repository to be able to download other Kubernetes version. Thus I believe it's important to include the 'version' keyword in this context, nonetheless of where it would be

What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My take was that if you are not using the official package repository, you may encounter problems other than versions missing. I was suggesting to make this as early as possible in this page, and to avoid restricting the problem to the version issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants