Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Add statement regarding ReadinessProbe manual run #47981

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[ja] Add statement regarding ReadinessProbe manual run #47981

merged 1 commit into from
Sep 18, 2024

Conversation

mochizuki875
Copy link
Member

@mochizuki875 mochizuki875 commented Sep 18, 2024 •
edited
Loading

コンテナがReadyになるまでの間、periodSecondsで指定したタイミングとは異なるタイミングでReadinessProbeが実行される仕様について明記しました。
本内容は英語版ドキュメントにも反映済です。

related: #47727

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization area/release-eng Issues or PRs related to the Release Engineering subproject area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes language/bn Issues or PRs related to Bengali language size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language labels Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 18, 2024
@mochizuki875 mochizuki875 changed the title [ja] Add statement regarding ReadinessProbe manual run WIP [ja] Add statement regarding ReadinessProbe manual run Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 18, 2024
@mochizuki875 mochizuki875 changed the title WIP [ja] Add statement regarding ReadinessProbe manual run [ja] Add statement regarding ReadinessProbe manual run Sep 18, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 18, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1a284c5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66ea54ff65073c0008af938f
😎 Deploy Preview https://deploy-preview-47981--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 18, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2b7ce28
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66ea55a7c8871e0008066695
😎 Deploy Preview https://deploy-preview-47981--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mochizuki875
Copy link
Member Author

/remove-area blog
/remove-area release-eng
/remove-area web-development
/remove-language bn
/remove-language en
/remove-language es
/remove-language fr
/remove-language hi
/remove-language id
/remove-language vi
/remove-language zh
/remove-sig release

@k8s-ci-robot k8s-ci-robot removed area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes language/bn Issues or PRs related to Bengali language language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 18, 2024
Okabe-Junya
Okabe-Junya reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Okabe-Junya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9ebf394b18e3a82a72a26712539cad00f977c6c4

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 23e2c03 into kubernetes:main Sep 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okabe-Junya Okabe-Junya Okabe-Junya left review comments

@bells17 bells17 Awaiting requested review from bells17

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607

Assignees

@Okabe-Junya Okabe-Junya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mochizuki875 @k8s-ci-robot @Okabe-Junya