Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added image volume type in ephemeral volumes #47918

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

saireddyb
Copy link
Contributor

Image volume type falls under ephemeral volumes.

Image volume type falls under ephemeral volumes.
Copy link

linux-foundation-easycla bot commented Sep 13, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 13, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @saireddyb!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 13, 2024
Copy link

netlify bot commented Sep 13, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f04a552
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66e484e978b3b500082c9865
😎 Deploy Preview https://deploy-preview-47918--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@salaxander
Copy link
Contributor

This is still an alpha feature right? Is that worth noting here?

@saireddyb
Copy link
Contributor Author

This is still an alpha feature right? Is that worth noting here?

I was excited about this feature and didn't find in ephemeral page.
So though to create my first PR.
Should I close this PR.

@tengqm
Copy link
Contributor

tengqm commented Sep 14, 2024

This is still an alpha feature right? Is that worth noting here?

I was excited about this feature and didn't find in ephemeral page. So though to create my first PR. Should I close this PR.

What @salaxander suggested was that the stage of the feature should be mentioned somewhere.
This is not a blocker to document it.
I'm as excited by this feature as you, and my perception is that we need to document this feature in more details so that people get to know about its usage and caveats.

@saireddyb
Copy link
Contributor Author

I'm as excited by this feature as you, and my perception is that we need to document this feature in more details so that people get to know about its usage and caveats.

ok, but the detailed info is already available here

@tengqm
Copy link
Contributor

tengqm commented Sep 14, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0bea4c899f694c9cd935cc629ec4be37804dd484

Copy link
Member

@mengjiao-liu mengjiao-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sftim
Copy link
Contributor

sftim commented Sep 14, 2024

/sig storage
/approve

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Sep 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit c43780d into kubernetes:main Sep 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants