Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update namespaces.md to remove monospace formatting in Note block #47778

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Update namespaces.md to remove monospace formatting in Note block #47778

merged 1 commit into from
Sep 4, 2024

Conversation

NommyNomm
Copy link
Contributor

Note block advising against the use of kube- prefixes was formatted as a mono space code block which stopped word wrapping.

Description

Issue

Closes: #

@NommyNomm
Update namespaces.md to remove monospace formatting in Note block
f6ddca1 
Note block advising against the use of `kube-` prefixes
was formatted as a mono space code block which stopped
word wrapping.
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 4, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 4, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 4, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @NommyNomm!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 4, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f6ddca1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66d7b82db20ebd0008418d10
😎 Deploy Preview https://deploy-preview-47778--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 4, 2024
@NommyNomm
Copy link
Contributor Author

CLA Not Signed

* [❌](https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/51478266/47778/#/?version=2) - login: @NommyNomm / name: Alex Tierney . The commit ([f6ddca1](https://github.com/kubernetes/website/commit/f6ddca16f9abd8db565a90b594362df572bb4bc4)) is not authorized under a signed CLA. [Please click here to be authorized](https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/51478266/47778/#/?version=2). For further assistance with EasyCLA, [please submit a support request ticket](https://jira.linuxfoundation.org/servicedesk/customer/portal/4).

This has been resolved/signed.

dipesh-rawat
dipesh-rawat reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Preview Page

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c4929677376ef1361d58f14e564632d7ac7a3b08

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit e2bd6ad into kubernetes:main Sep 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@thockin thockin Awaiting requested review from thockin

Assignees

@dipesh-rawat dipesh-rawat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NommyNomm @k8s-ci-robot @dipesh-rawat