-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote RetryGenerateName to GA in 1.32 #47770
Promote RetryGenerateName to GA in 1.32 #47770
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have name generation very briefly mentioned in https://kubernetes.io/docs/concepts/overview/working-with-objects/names/, along with the fact that the API server tries more than once to generate a name but may give up eventually.
/milestone 1.32 |
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
I've added a paragraph to the page. PTAL |
content/en/docs/concepts/overview/working-with-objects/names.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates/retry-generate-name.md
Show resolved
Hide resolved
Co-authored-by: Qiming Teng <tengqm@outlook.com>
All the kubernetes/kubernetes and kubernetes/enhnacements changes for this promotion have merged. This can merge when ready. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This just needs LGTM to merge. The implementation is merged. @sftim Would you be willing to LGTM? |
Friendly nudge that this is ready to merge |
/lgtm |
LGTM label has been added. Git tree hash: 2fb42e6b5ee07c1235459d3193fe804c2b592d64
|
Description
Promote the RetryGenerateName feature to GA
/sig api-machinery
/hold
until kubernetes/kubernetes#127093 merges