Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote RetryGenerateName to GA in 1.32 #47770

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Sep 3, 2024

Description

Promote the RetryGenerateName feature to GA

/sig api-machinery

/hold
until kubernetes/kubernetes#127093 merges

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Sep 3, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2024
@jpbetz jpbetz changed the base branch from main to dev-1.32 September 3, 2024 14:56
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2024
Copy link

netlify bot commented Sep 3, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 31aba2f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66f4b48bf70602000846362c
😎 Deploy Preview https://deploy-preview-47770--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have name generation very briefly mentioned in https://kubernetes.io/docs/concepts/overview/working-with-objects/names/, along with the fact that the API server tries more than once to generate a name but may give up eventually.

@reylejano
Copy link
Member

/milestone 1.32

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Sep 3, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2024
Copy link

netlify bot commented Sep 23, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 31aba2f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66f4b48bbf47f200084f2b2c

@jpbetz
Copy link
Contributor Author

jpbetz commented Sep 23, 2024

I'd like to have name generation very briefly mentioned in https://kubernetes.io/docs/concepts/overview/working-with-objects/names/, along with the fact that the API server tries more than once to generate a name but may give up eventually.

I've added a paragraph to the page. PTAL

jpbetz and others added 2 commits September 26, 2024 01:08
@jpbetz
Copy link
Contributor Author

jpbetz commented Sep 26, 2024

All the kubernetes/kubernetes and kubernetes/enhnacements changes for this promotion have merged. This can merge when ready.

@tengqm
Copy link
Contributor

tengqm commented Sep 26, 2024

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 1, 2024

This just needs LGTM to merge. The implementation is merged.

@sftim Would you be willing to LGTM?

@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 7, 2024

Friendly nudge that this is ready to merge

@tengqm
Copy link
Contributor

tengqm commented Oct 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2fb42e6b5ee07c1235459d3193fe804c2b592d64

@k8s-ci-robot k8s-ci-robot merged commit e132a42 into kubernetes:dev-1.32 Oct 7, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants