Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube_pod_resource_request metric is now stable #47471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

kube_pod_resource_request metric is now stable #47471

wants to merge 1 commit into from
+6 −3

Conversation

ringerc
Copy link

@ringerc ringerc commented Aug 13, 2024

Description

The kube scheduler metrics docs at https://kubernetes.io/docs/concepts/cluster-administration/system-metrics/#kube-scheduler-metrics incorrectly stated that the metrics kube_pod_resource_request and kube_pod_resource_limit are only available when passing the scheduler argument --show-hidden-metrics-for-version=1.20.

This argument is not permitted on newer k8s with this value (it must be the same or one lower version than the running k8s), and it's unnecessary since these metrics are in the stable set now anyway: https://kubernetes.io/docs/reference/instrumentation/metrics/

Issue

nil

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 13, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ringerc / name: Craig Ringer (4aa44ee)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign katcosgrove for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 13, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ringerc!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 13, 2024
@ringerc
kube_pod_resource_request metric is now stable
4aa44ee 
There's no longer any need to specify the --show-hidden-metrics-for-version
option to the scheduler to see the kube_pod_resource_request metric, it in the
stable set now.

Also mention that authorization must be for /metrics/resources. Simply having
/metrics is not enough.
@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8b1c700
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66bacc6c444999000841cc7d
😎 Deploy Preview https://deploy-preview-47471--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4aa44ee
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66baccf543245b0009601a99
😎 Deploy Preview https://deploy-preview-47471--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shubham82
Copy link
Contributor

Hi @ringerc
you have to sign the CLA before the PR can be reviewed.
See the following document to sign the CLA: The Contributor License Agreement

@Shubham82
Copy link
Contributor

To check EasyCLA

/easycla

@ringerc
Copy link
Author

ringerc commented Aug 14, 2024 •
edited
Loading

Thanks @Shubham82 . I'm trying to find out who in my org can approve it. What a painful process for a small docs PR.

Arhell
Arhell reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@reylejano
Copy link
Member

@ringerc please sign the CLA
#47471 (comment)

@ringerc
Copy link
Author

ringerc commented Sep 5, 2024 •
edited
Loading

@reylejano I'm trying, I'm trying. Lots of other things being juggled.

@ringerc
Copy link
Author

ringerc commented Nov 3, 2024

CLA should be signed soon.

@ringerc
Copy link
Author

ringerc commented Nov 6, 2024

I've been unable to get the signed CLA accepted, and will raise a support ticket.

@molssongroup
Copy link

/easycla

@ringerc
Copy link
Author

ringerc commented Nov 11, 2024 •
edited
Loading

CLA issues resolved. The org had 2 separate orgs registered with the CLA, and only one was working. Rather confusing. Signed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@brancz brancz Awaiting requested review from brancz

@RainbowMango RainbowMango Awaiting requested review from RainbowMango

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ringerc @k8s-ci-robot @Shubham82 @reylejano @molssongroup @Arhell