Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update structure and create new index.md ES translation #47447

Merged
merged 20 commits into from
Sep 3, 2024
Merged

feat: update structure and create new index.md ES translation #47447

merged 20 commits into from
Sep 3, 2024

Conversation

krol3
Copy link
Contributor

@krol3 krol3 commented Aug 12, 2024

Description

  • New translation : content/es/docs/tasks/debug/_index.md
  • the other files are only moving to keep the new structure

Issue

Related to #47444

Closes: #

@krol3
feat: update structure and create new index.md ES translation
f58635a 
Signed-off-by: carolina valencia <krol3@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Aug 12, 2024
@k8s-ci-robot k8s-ci-robot added language/es Issues or PRs related to Spanish language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 12, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 12, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit af9ee01
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66d363a6c5f72300087b4cd4
😎 Deploy Preview https://deploy-preview-47447--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend some tweaks.

content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
electrocucaracha
electrocucaracha suggested changes Aug 14, 2024
View reviewed changes
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
content/es/docs/tasks/debug/_index.md Outdated Show resolved Hide resolved
@krol3
chore: adjust text after review-01
7440b85 
Signed-off-by: carolina valencia <krol3@users.noreply.github.com>
@krol3
Copy link
Contributor Author

krol3 commented Aug 17, 2024

Thanks for the review @sftim and @electrocucaracha. I considered all your comments.

@electrocucaracha
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 14ef6371f4d723fb585b74ff0d94937b4e4ee197

ramrodo
ramrodo suggested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@ramrodo ramrodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions and typos.

@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
5176e07 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2024
krol3 and others added 17 commits August 30, 2024 13:03
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
0e64884 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
2c1a41a 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
e6a8fd2 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
566c558 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
d69983b 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
2f6648e 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
d0bb789 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
1fd913c 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
42eef0c 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
8badbfb 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
f8f5d05 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
a94266f 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
88bef6c 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
c5d20eb 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
f449865 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
42e0faf 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 @ramrodo
Update content/es/docs/tasks/debug/_index.md
af9ee01 
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
@krol3 krol3 requested a review from ramrodo September 1, 2024 22:16
@ramrodo
Copy link
Member

ramrodo commented Sep 3, 2024

Great!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b224b0a773a3d1c355e1600198529f919d5b86b3

@electrocucaracha
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 96efb96 into kubernetes:main Sep 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@ramrodo ramrodo Awaiting requested review from ramrodo

Assignees

@electrocucaracha electrocucaracha

@ramrodo ramrodo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krol3 @electrocucaracha @k8s-ci-robot @ramrodo @sftim