Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beta pre-requisites from validating admission policies docs #47335

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

nagygergo
Copy link
Contributor

With 1.30 stable, the feature does not need to be enabled and the v1beta1 API group is not needed.

Description

Issue

Closes: #

With 1.30 stable, the feature does not need to be enabled and the v1beta1 API group is not needed.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 1, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @nagygergo!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2024
@nagygergo nagygergo changed the title Remove beta pre-requisites Remove beta pre-requisites from validating admission policies docs Aug 1, 2024
Copy link

netlify bot commented Aug 1, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d77111d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66ab347502443f000801f0ab
😎 Deploy Preview https://deploy-preview-47335--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0c108ca9f7f5d50f66eabd5ec511269ed062c8e7

@kundan2707
Copy link
Contributor

Preview

@kundan2707
Copy link
Contributor

/lgtm

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

If you'd also like to update the rest of the page @nagygergo, you could review our style guide and propose updates where this document isn't aligned to it.

This change is good to merge!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit a4a8dae into kubernetes:main Aug 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants