-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Add a blog post with a clientcmd tutorial #47263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks. Please hold whilst we find a reviewer. /hold |
* files can be specified using the `KUBECONFIG` environment variable; | ||
* all the above can be further overridden using command-line arguments. | ||
|
||
One major missing piece for full `kubectl`-style argument handling is support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One major missing piece for full `kubectl`-style argument handling is support | |
One major missing piece for complete `kubectl` style argument handling is the support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve rephrased it:
It doesn’t set up a `--kubeconfig` flag,
which you might want to do to align with `kubectl`;
you’ll see how to do this [later on](#bind-the-flags).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats good. Maybe you can rewrite the last one as you'll see how to do this in [bind-the-flags] section later in this blog
Current one is ok as well. It just add some more direct reference here.
574623f
to
568ee53
Compare
// Loading rules, no configuration | ||
loadingRules := clientcmd.NewDefaultClientConfigLoadingRules() | ||
|
||
// Overrides and flag setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's one way to reconcile github.com/spf13/pflag
with the jargon from the wider world of IT.
// Overrides and flag setup | |
// Overrides and flag (command line option) setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or “command line argument” to avoid yet another term 😉.
70c7020
to
5357f00
Compare
Hi. We're now looking at publication in September 2024. |
2f1eb36
to
7e306a2
Compare
How about publication on the 26th? Please aim for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Here's some feedback that I think would get this good to merge.
76cc61c
to
246dcf8
Compare
OK! This needs a tech review next. Either SIG CLI or SIG API Machinery; take your pick. |
I vote for SIG CLI. |
246dcf8
to
9216604
Compare
@sftim is it up to me to request a technical review from SIG CLI? |
Hi. The blog team is short on capacity, so reviews are taking a long time. How about we aim for publication on the 2nd of December? |
Signed-off-by: Stephen Kitt <skitt@redhat.com>
9216604
to
9a77ed1
Compare
OK, I’ve amended the PR accordingly. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
As per above discussion, the PR is still waiting for reviews so removing the tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the wait on this.
Would you still like to publish it?
This adds a blog post giving instructions on how to use
clientcmd
to handlekubectl
-style command-line options in CLI tools.