Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify likely etcd restart steps for etcdctl-based restore. #47167

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

dr0ptp4kt
Copy link
Contributor

For many, maybe most, installations of etcd, when etcd is restored with etcdctl, when the etcd pod YAML is edited to point at a new restore location, the pod will also need to be restarted and the kubelet restarted in order for etcd to become fully operational again with the new backup. Some basic guidance is provided for use of the (legacy) etcdctl instructions as a reminder.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jpbetz July 15, 2024 18:31
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 15, 2024
Copy link

netlify bot commented Jul 15, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 763f0f0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a2a5dbb0692700088fa721
😎 Deploy Preview https://deploy-preview-47167--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@T-Lakshmi
Copy link
Contributor

@dr0ptp4kt,
Can you please look into the @tengqm suggestions and apply those whenever you get chance to work on it.

@dr0ptp4kt
Copy link
Contributor Author

Thanks @T-Lakshmi for the the reminder. On it.

@dr0ptp4kt
Copy link
Contributor Author

@T-Lakshmi @tengqm Okay, updated, I hope in the spirit of what was requested. Please let me know if any sort of squash commit is needed. Although I had merged locally into my patch-2 branch and pushed to it, it seemed to not take, so I used the web editor to make the final commit to make it stick.

@tengqm
Copy link
Contributor

tengqm commented Jul 26, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8d63dcf64f72b7678243cfc646ba5df4595b48bf

@T-Lakshmi
Copy link
Contributor

@T-Lakshmi @tengqm Okay, updated, I hope in the spirit of what was requested. Please let me know if any sort of squash commit is needed. Although I had merged locally into my patch-2 branch and pushed to it, it seemed to not take, so I used the web editor to make the final commit to make it stick.

That would be fine.

@T-Lakshmi
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 26, 2024
@salaxander
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: salaxander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0e55112 into kubernetes:main Jul 26, 2024
6 checks passed
hacktivist123 pushed a commit to hacktivist123/website that referenced this pull request Jul 29, 2024
…tes#47167)

* Specify likely etcd restart steps for etcdctl-based restore.

* Specify likely etcd restart steps for etcdctl-based restore.

* Update configure-upgrade-etcd.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants