Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configure-liveness-readiness-startup-probes.md #47098

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

sankalp-khare
Copy link
Contributor

@sankalp-khare sankalp-khare commented Jul 4, 2024

Changes

  • Flip the order in which liveness and readiness probes are discussed in the TCP liveness probe section, because that makes more sense (the item in the section title first, the extra item after it)
  • Some phrasing / language improvements in other sections

View the edited section as rendered markdown: https://github.com/sankalp-khare/website/blob/patch-1/content/en/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes.md#define-a-tcp-liveness-probe

Flip the order in which liveness and readiness probes are discussed in the TCP liveness probe section, because that makes more sense.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 4, 2024
Copy link

netlify bot commented Jul 4, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d0b1889
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66870e2f98e772000808dbb0
😎 Deploy Preview https://deploy-preview-47098--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 4, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3f433a2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6687125c4e9dfc000863748f
😎 Deploy Preview https://deploy-preview-47098--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Some more edits as I read through the page...
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2024
@salaxander
Copy link
Contributor

I think this change makes sense. Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5ec3b77f04a59b0601db6e20231aaf4697d679e1

@tengqm tengqm added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 26, 2024
@tengqm
Copy link
Contributor

tengqm commented Jul 26, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 78c0660 into kubernetes:main Jul 26, 2024
6 checks passed
hacktivist123 pushed a commit to hacktivist123/website that referenced this pull request Jul 29, 2024
* Update configure-liveness-readiness-startup-probes.md

Flip the order in which liveness and readiness probes are discussed in the TCP liveness probe section, because that makes more sense.

* Some updates

* More updates

Some more edits as I read through the page...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants