Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-4568: Resilient Watch Cache Initialization: Add feature gate docs #47002

Closed
wants to merge 1 commit into from

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Jun 27, 2024

KEP: Resilient Watchcache Initialization

cc @wojtek-t I don't know if we need any docs for this feature, but I got pinged about getting a placeholder docs PR in place so I took the liberty of creating this. Feel free to comment or take it over.

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jun 27, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2024
Copy link

netlify bot commented Jun 27, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit bd50149
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/667dbfb75ef83c00084704ae

Copy link

netlify bot commented Jun 27, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit bd50149
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/667dbfb79053650008d11f42
😎 Deploy Preview https://deploy-preview-47002--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chanieljdan
Copy link
Contributor

Thanks @jpbetz!
Link to associated KEP: Resilient Watchcache Initialization

@dipesh-rawat
Copy link
Member

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 28, 2024
@@ -0,0 +1,14 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpbetz - I don't think we need any other docs specifically for this change.

But we have a second feature gate - I opened #47063 to contain both.
We should either proceed with mine or you can rebase yours and I can close mine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @wojtek-t and @jpbetz, have you both decided on which of the PRs to go with?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @wojtek-t and @jpbetz, have you both decided on which of the PRs to go with?

Hi @wojtek-t and @jpbetz have you decided on which to go forward with? That way, we can close one of them out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will proceed with #47063

@chanieljdan
Copy link
Contributor

Hi @wojtek-t and @jpbetz,

Reaching out from the Docs team, just checking in as we approach Docs Freeze on Tuesday July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze.

Looks like we're deciding on which PR to go with, could you let us know which to move forward with? We can close the one that's not needed out.

Thank you!

Daniel

@wojtek-t
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@wojtek-t: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants