Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog post for KEP-3619: Fine-grained SupplementalGroups control #46921

Merged
merged 7 commits into from
Aug 13, 2024
Merged

blog post for KEP-3619: Fine-grained SupplementalGroups control #46921

merged 7 commits into from
Aug 13, 2024

Conversation

everpeace
Copy link
Contributor

@everpeace everpeace commented Jun 22, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Jun 22, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2024
@everpeace everpeace force-pushed the blog-KEP-3619-SupplementalGroupsPolicy branch from 0cc4f10 to 2f80911 Compare June 22, 2024 08:58
@everpeace everpeace mentioned this pull request Jun 22, 2024
Open
24 tasks
@netlify Netlify
Copy link

netlify bot commented Jun 22, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0cc4f10
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66769208e7e23a00085bd9ae
😎 Deploy Preview https://deploy-preview-46921--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 22, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fee94ce
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66b424f80680720008686d05
😎 Deploy Preview https://deploy-preview-46921--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Jun 23, 2024

/hold

pending assignment of publication date (by release comms)

we'll also keep this held until the v1.31 release has happened

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2024
@everpeace everpeace force-pushed the blog-KEP-3619-SupplementalGroupsPolicy branch from 2f80911 to 4054158 Compare July 11, 2024 17:11
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2024
@mbianchidev
Copy link
Member

Hey @everpeace , it's Matteo from the 1.31 Release comms team.
I'm reaching out with a reminder that the blog ready for review deadline is July 26, 2024.

Please let me know how we can help with content, review or anything else 😄

@everpeace everpeace force-pushed the blog-KEP-3619-SupplementalGroupsPolicy branch from 4054158 to 4618812 Compare July 23, 2024 12:01
@everpeace everpeace marked this pull request as ready for review July 24, 2024 12:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2024
@everpeace everpeace force-pushed the blog-KEP-3619-SupplementalGroupsPolicy branch from 4618812 to 32d19d3 Compare July 24, 2024 12:37
everpeace
everpeace commented Jul 24, 2024
View reviewed changes
Copy link
Contributor Author

@everpeace everpeace left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thockin @mrunalp @SergeyKanzhelev
cc/ @haircommander

Could you review this feature blog PR?

The content is mostly based on docs PR: #46920

Preview:https://deploy-preview-46921--kubernetes-io-main-staging.netlify.app/blog/2024/08/22/fine-grained-supplementalgroups-control/

@mbianchidev
Copy link
Member

HI @everpeace

Your publication date is currently set for the 22nd of August.

Do you need anything from the comms team?
I see a great deal of review going on but if you need an additional pair of eyes let me know!

@everpeace
Copy link
Contributor Author

@mbianchidev

Your publication date is currently set for the 22nd of August.

Cool. Thanks!

I see a great deal of review going on but if you need an additional pair of eyes let me know!

Why not? Please. I'd be appreciated if I can get more feedbacks!

mbianchidev
mbianchidev approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@mbianchidev mbianchidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review is mostly on the content side and that I think is super good, I just added some suggestions for clarity and consistency of the blog itself.

I haven't tried the changes but che yaml files also seem to be correct.

+1 from me

content/en/blog/_posts/xxxx-xx-xx-Fine-grained-SupplementalGroups-control/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/xxxx-xx-xx-Fine-grained-SupplementalGroups-control/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/xxxx-xx-xx-Fine-grained-SupplementalGroups-control/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/xxxx-xx-xx-Fine-grained-SupplementalGroups-control/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/xxxx-xx-xx-Fine-grained-SupplementalGroups-control/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/xxxx-xx-xx-Fine-grained-SupplementalGroups-control/index.md Outdated Show resolved Hide resolved
everpeace
everpeace commented Jul 29, 2024
View reviewed changes
Copy link
Contributor Author

@everpeace everpeace left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbianchidev Thank you for your feedback. I replaced xxxx-xx-xx with 2024-08-22 (including renaming directories/files) and accepted your suggestions. PTAL.

mbianchidev
mbianchidev approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@mbianchidev mbianchidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me

@mbianchidev
Copy link
Member

Hey @natalisucks !

Can you review this one and if everything looks good label it? 👀

@everpeace @sftim
Apply suggestions from code review
fee94ce 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
everpeace
everpeace commented Aug 8, 2024
View reviewed changes
Copy link
Contributor Author

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim Thanks for your improvement suggestions. I addressed them. PTAL 🙇

@natalisucks
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbianchidev, natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@sftim
Copy link
Contributor

sftim commented Aug 8, 2024

/lgtm

🛑 Do not unhold or merge before Kubernetes v1.31 is released 🛑

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 33a495120e83bad93c5718409990a297b172dbfa

@dipesh-rawat
Copy link
Member

/unhold

Kubernetes v1.31 has been released.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 73b7b14 into kubernetes:main Aug 13, 2024
6 checks passed
@everpeace everpeace deleted the blog-KEP-3619-SupplementalGroupsPolicy branch August 14, 2024 01:43
This was referenced Aug 14, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@haircommander haircommander haircommander left review comments

@mbianchidev mbianchidev mbianchidev approved these changes

@Gauravpadam Gauravpadam Awaiting requested review from Gauravpadam

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@everpeace @sftim @mbianchidev @natalisucks @k8s-ci-robot @dipesh-rawat @haircommander