-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update garbage-collection.md for misleading "ImageMaximumGCAge" configuration option #46810
Conversation
The documentation about the feature gate and option field "ImageMaximumGCAge" is misleading. The option field for the kubelet configuration is camelCase and needs to start with a lowercase "i" instead of an uppercase "I" (like for the feature gate option).
The committers listed above are authorized under a signed CLA. |
Welcome @chillje! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@chillje Thanks you for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/easycla
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
LGTM label has been added. Git tree hash: 3ce282a10847f41ca65a96071c0a8736a9f043cb
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The documentation about the feature gate and option field "ImageMaximumGCAge" is misleading. The option field for the kubelet configuration is camelCase and needs to start with a lowercase "i" instead of an uppercase "I" (like for the feature gate option).