-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bn] Adding shortcode upcoming-releases.html #46210
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @dipesh-rawat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change of copying the upcoming-releases shotrcode source to the Bengali language dev branch looks good to me!
/lgtm
/approve
(Unofficially giving the nod of approval; the dev-1.24-bn.1/OWNERS_ALIASES is not currently synced with main for me to be able to approve this; officially need an approval from sig-docs-en-owners in dev-1.24-bn.1/OWNERS_ALIASES
@reylejano Requesting for approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best thing to do for this is to merge in the main branch.
/hold
/lgtm cancel This is the wrong way to do it; instead, I'd prefer to see either:
If taking option #2, someone will need to update the patch releases page in Bengali after the localization has launched. This is OK; after any localization launches, there is still lots of work that people can do to improve it. |
@sftim Thanks for suggestion , we are going with option 2 |
Closing this issue in favor of this #45009. |
Adding shortcode upcoming-releases.html in bn version to solve this error