Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bn] Adding shortcode upcoming-releases.html #46210

Closed

Conversation

asem-hamid
Copy link
Contributor

Adding shortcode upcoming-releases.html in bn version to solve this error

image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 6, 2024
@asem-hamid
Copy link
Contributor Author

/cc @dipesh-rawat

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change of copying the upcoming-releases shotrcode source to the Bengali language dev branch looks good to me!

/lgtm
/approve (Unofficially giving the nod of approval; the dev-1.24-bn.1/OWNERS_ALIASES is not currently synced with main for me to be able to approve this; officially need an approval from sig-docs-en-owners in dev-1.24-bn.1/OWNERS_ALIASES

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024
@asem-hamid
Copy link
Contributor Author

@reylejano Requesting for approval

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best thing to do for this is to merge in the main branch.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@sftim
Copy link
Contributor

sftim commented May 6, 2024

/lgtm cancel

This is the wrong way to do it; instead, I'd prefer to see either:

  1. a PR merging main into dev-1.24-bn.1
  2. the localized text for the Bengali patch releases page being a localized version for the merge base of dev-1.24-bn.1
    In less technical language: localize an older version of that page that doesn't rely on this missing shortcode

If taking option #2, someone will need to update the patch releases page in Bengali after the localization has launched. This is OK; after any localization launches, there is still lots of work that people can do to improve it.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024
@asem-hamid
Copy link
Contributor Author

@sftim Please check out this PR

@asem-hamid
Copy link
Contributor Author

@sftim Thanks for suggestion , we are going with option 2

@asem-hamid
Copy link
Contributor Author

Closing this issue in favor of this #45009.

@asem-hamid asem-hamid closed this May 10, 2024
@asem-hamid asem-hamid deleted the Adding-Shortcode branch May 10, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants