Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document NameGenerationRetries feature gate #45154

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Document NameGenerationRetries feature gate #45154

merged 2 commits into from
Mar 20, 2024

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Feb 15, 2024

Enhancement Issue: kubernetes/enhancements#4420
Enhancement PR: kubernetes/kubernetes#122887

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language labels Feb 15, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2024
@jpbetz jpbetz mentioned this pull request Feb 15, 2024
Open
12 tasks
@netlify Netlify
Copy link

netlify bot commented Feb 15, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit cda663f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65ce48e962b4530008abe043
😎 Deploy Preview https://deploy-preview-45154--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dipesh-rawat
dipesh-rawat reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpbetz, perhaps we should consider setting the dev-1.30 branch as the target branch rather than the main branch for this pull request. Since the change is related to the feature targeting 1.30.

@jpbetz jpbetz changed the base branch from main to dev-1.30 February 15, 2024 18:13
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 15, 2024
@dipesh-rawat
Copy link
Member

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Feb 15, 2024
@reylejano
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Feb 16, 2024
@jpbetz jpbetz marked this pull request as ready for review February 21, 2024 02:47
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Feb 21, 2024

Implementation has merged. This can merge when ready.

@jpbetz
Copy link
Contributor Author

jpbetz commented Feb 29, 2024

Friendly nudge for review. The feature is merged.

@Vyom-Yadav
Copy link
Member

Hey @jpbetz 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday March 12th 2024 18:00 PST. Thank you!

I think this is ready for review so just a friendly reminder :)

sftim
sftim previously requested changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

A few tweaks and this is fine for alpha.

For beta, as a side effect of the graduation, we should update https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names to mention the retry behavior (regardless of whether or not the feature gate is enabled by default).

content/en/docs/reference/command-line-tools-reference/feature-gates/name-generation-retries.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates/name-generation-retries.md Outdated Show resolved Hide resolved
@jpbetz @sftim
Apply suggestions from code review
8072b0b 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@netlify Netlify
Copy link

netlify bot commented Mar 6, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 8072b0b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65e7c25cd526e20008b492be

@tengqm
Copy link
Contributor

tengqm commented Mar 6, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 12, 2024

@deads2k this one could use an LGTM

@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 19, 2024

Would someone be willing to LGTM? This is small and ready to merge.

@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 20, 2024

@sftim Would you be willing to LGTM this one?

@drewhagen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8e5a2c7df82ab4593b054d8022916d71b4abe7ac

@k8s-ci-robot k8s-ci-robot merged commit 29bb68b into kubernetes:dev-1.30 Mar 20, 2024
6 checks passed
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@sftim sftim sftim left review comments

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@reylejano reylejano Awaiting requested review from reylejano

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees

@drewhagen drewhagen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
8 participants
@jpbetz @dipesh-rawat @reylejano @Vyom-Yadav @tengqm @k8s-ci-robot @drewhagen @sftim