Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access-cluster-services.md list indent #44831

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix access-cluster-services.md list indent #44831

merged 1 commit into from
Jan 23, 2024

Conversation

1000Delta
Copy link
Contributor

@1000Delta 1000Delta commented Jan 21, 2024 •
edited
Loading

Fix list indent in the section: Ways to connect

The correct list should have 3 method to connect nodes/pods/services:

  • Public IP
  • kubectl proxy
  • From a pod/node in the cluster

See preview.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jan 21, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 21, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 586fd88
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65acd2d29d7b080008f36049
😎 Deploy Preview https://deploy-preview-44831--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

T-Lakshmi
T-Lakshmi reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@T-Lakshmi T-Lakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview page
The changes are appropriate.
LGTM

@Princesso
Copy link
Contributor

/lgtm
/assign @divya-mohan0209

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e521f67b6dd8c0015e16534fe95a627d193db26

divya-mohan0209
divya-mohan0209 reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit ca81744 into kubernetes:main Jan 23, 2024
6 checks passed
@windsonsea windsonsea mentioned this pull request Jan 24, 2024
Merged
@1000Delta 1000Delta deleted the fix_access-cluster-services branch January 31, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Lakshmi T-Lakshmi T-Lakshmi left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@reylejano reylejano Awaiting requested review from reylejano

Assignees

@Princesso Princesso

@divya-mohan0209 divya-mohan0209

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@1000Delta @Princesso @k8s-ci-robot @divya-mohan0209 @T-Lakshmi