Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uk] remove whitespace #44830

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[uk] remove whitespace #44830

merged 1 commit into from
Jan 23, 2024

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Jan 21, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/uk Issues or PRs related to Ukrainian language labels Jan 21, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 21, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d017ec5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65accc9ef5f79e0008b0dd8d
😎 Deploy Preview https://deploy-preview-44830--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim reviewed Jan 21, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes whitespace, not an indentation.

LGTM

@sftim
Copy link
Contributor

sftim commented Jan 21, 2024

It does feel like a trivial edit - unless I missed something?

@nate-double-u
Copy link
Contributor

I agree @sftim. I'll leave closing this to one of the UK editors in case we are missing something (a little odd I was automatically added to review this one, usually I don't get localization PRs assigned).

@Arhell Arhell changed the title [uk] remove indent [uk] remove whitespace Jan 22, 2024
@MaxymVlasov
Copy link
Member

@Arhell, if you can, please next time reviewing PRs more carefully, because that fix can be done during your review of #44813 a few days ago. No blame, just a friendly request to keep the repo git history cleaner when possible :)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3c8a94e2edc2ef8f788fbff398edc019211a20d3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaxymVlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit f953fc8 into kubernetes:main Jan 23, 2024
6 checks passed
@Arhell Arhell deleted the uk-fix branch January 23, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@MaxymVlasov MaxymVlasov Awaiting requested review from MaxymVlasov

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@MaxymVlasov MaxymVlasov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/uk Issues or PRs related to Ukrainian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Arhell @sftim @nate-double-u @MaxymVlasov @k8s-ci-robot