Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] sync persistent-volumes.md #44789

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Conversation

0xff-dev
Copy link
Contributor

[zh] sync persistent-volumes.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language labels Jan 18, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2024
Copy link

netlify bot commented Jan 18, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 47f7260
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65ab892fe8bde90008252b93
😎 Deploy Preview https://deploy-preview-44789--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

尽量在原有基础上优化,try to add value.

content/zh-cn/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
content/zh-cn/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
content/zh-cn/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
content/zh-cn/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
content/zh-cn/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
content/zh-cn/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
content/zh-cn/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
content/zh-cn/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
content/zh-cn/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
content/zh-cn/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to confirm whether all suggestions have been applied?

content/zh-cn/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
content/zh-cn/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
@@ -461,8 +464,6 @@ The following is an example

```shell
kubectl describe pv pvc-74a498d6-3929-47e8-8c02-078c1ece4d78
```
```none
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 464-465 可以保留,把 命令和输出分开是比较好的一个做法

The blog article
[Introducing Single Pod Access Mode for PersistentVolumes](/blog/2021/09/13/read-write-once-pod-access-mode-alpha/)
covers this in more detail.
{{< note >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{< note >}} 短代码的处理,参考 中文本地化指南

@tengqm
Copy link
Contributor

tengqm commented Jan 21, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1047d645d4b81d8d7d7c4f80b031844044bd94c6

Copy link
Member

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ydFu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit bcbd218 into kubernetes:main Jan 21, 2024
6 checks passed
@0xff-dev 0xff-dev deleted the sync-pv branch January 21, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants