Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update encrypt-data.md #44776

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Update encrypt-data.md #44776

merged 1 commit into from
Jan 19, 2024

Conversation

BRONSOLO
Copy link
Contributor

Fix as ---> at typo

Small typo fix.

@BRONSOLO
Update encrypt-data.md
b1929ab 
Fix as ---> at typo
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 17, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: BRONSOLO / name: Chuck Bronson (b1929ab)

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 17, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 17, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @BRONSOLO!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 17, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 17, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b1929ab
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65a7f50ae634ef000887c167
😎 Deploy Preview https://deploy-preview-44776--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

@BRONSOLO Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: CLA Steps

dipesh-rawat
dipesh-rawat reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 17, 2024
@Shubham82
Copy link
Contributor

Thanks, @BRONSOLO
The preview looks good
https://deploy-preview-44776--kubernetes-io-main-staging.netlify.app/docs/tasks/administer-cluster/encrypt-data/#cleanup-all-secrets-encrypted

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ba66db9e33bf32d40737804324a16ce9f8aeb89c

kundan2707
kundan2707 reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BRONSOLO thanks for correction.

@kundan2707
Copy link
Contributor

/lgtm

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit fbf9b4f into kubernetes:main Jan 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kundan2707 kundan2707 kundan2707 left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@enj enj Awaiting requested review from enj

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@Shubham82 Shubham82

@kundan2707 kundan2707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BRONSOLO @k8s-ci-robot @dipesh-rawat @Shubham82 @kundan2707 @reylejano