Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update networkpolicy.yaml - match yaml code formatting #44503

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Update networkpolicy.yaml - match yaml code formatting #44503

merged 1 commit into from
Jan 22, 2024

Conversation

mhash17
Copy link
Contributor

@mhash17 mhash17 commented Dec 24, 2023

Harmonizing indent of the yaml to be equal in formatting to other code examples in network-policies.md

@mhash17
Update networkpolicy.yaml
f04d1d6 
Harmonizing indent of the yaml to be equal in formatting to other code examples in network-policies.md
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 24, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 24, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 24, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 24, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f04d1d6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6588b05f2008210008864e11
😎 Deploy Preview https://deploy-preview-44503--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Arhell
Arhell reviewed Dec 25, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign CLA

dipesh-rawat
dipesh-rawat reviewed Dec 25, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

PranitRout07
PranitRout07 reviewed Dec 25, 2023
View reviewed changes
Copy link
Contributor

@PranitRout07 PranitRout07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no need of changes .

@mhash17
Copy link
Contributor Author

mhash17 commented Dec 25, 2023

See my explanation:
#44502 (comment)

@mhash17
Copy link
Contributor Author

mhash17 commented Dec 25, 2023

If i sign EasyCLA it becomes 'covered' afther some time again 'uncovered'. I do not understand why..

@Gauravpadam
Copy link
Member

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 15, 2024
Gauravpadam
Gauravpadam reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@Gauravpadam Gauravpadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

I would prefer the indentations because

  1. They improve code readability in larger code samples (like this one)
  2. Both cases are correct in terms of linting

@natalisucks
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f99282b0ff9d9fdf66d6f84642033979a1ae954c

@divya-mohan0209
Copy link
Contributor

Thank you for these changes!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit bc36254 into kubernetes:main Jan 22, 2024
6 checks passed
@windsonsea windsonsea mentioned this pull request Jan 23, 2024
Merged
@kundan2707 kundan2707 mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PranitRout07 PranitRout07 PranitRout07 left review comments

@Arhell Arhell Arhell left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@Gauravpadam Gauravpadam Gauravpadam left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@natalisucks natalisucks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mhash17 @Gauravpadam @natalisucks @k8s-ci-robot @divya-mohan0209 @dipesh-rawat @Arhell @PranitRout07