Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Add a feature section content "self-healing" #43979

Closed
wants to merge 1 commit into from

Conversation

IbukiMnw
Copy link

Add a missing feature sections content in "ja". the title of new content is "self-healing" in "en".

Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nasa9084 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Nov 17, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 17, 2023
Copy link

netlify bot commented Nov 17, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 10b2489
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/655706d4d72b9300070eef24
😎 Deploy Preview https://deploy-preview-43979--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

@IbukiMnw Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: CLA Steps

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@dipesh-rawat
Copy link
Member

/retitle [ja] Add a feature section content "self-healing"

@k8s-ci-robot k8s-ci-robot changed the title add a feature section content "self-healing" in "ja" [ja] Add a feature section content "self-healing" Nov 17, 2023
@atoato88
Copy link
Contributor

The URL for the page on deploy preview for reviewing the content updated:

Copy link
Contributor

@atoato88 atoato88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments.

content_type: concept
weight: 20
weight: 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is 20 on the content of en.
What is the reason for updating this value with 30?

@@ -1,8 +1,15 @@
---
reviewers:
title: ReplicaSet
feature:
title: セルフヒーリング
anchor: ReplicaSetがどのように動くか {#how-a-replicaset-works}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
anchor: ReplicaSetがどのように動くか {#how-a-replicaset-works}
anchor: how-a-replicaset-works

Current code renders #replicasetがどのように動くか-how-a-replicaset-works as anchor, so specify the anchor ID included in the ja content.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@atoato88
Copy link
Contributor

@IbukiMnw
Sorry for mention you, how about the sign to the CLA and updating the content?

@atoato88
Copy link
Contributor

@IbukiMnw
Gentle ping.

Is there any problem about signing the CLA?
If so, please refer this article for checking the CLA process in Japanese.

Besides, please feel free to contact me.

@Gauravpadam
Copy link
Member

Closing this as the CLA status is still red
Please feel free to re-open this

/close

@k8s-ci-robot
Copy link
Contributor

@Gauravpadam: Closed this PR.

In response to this:

Closing this as the CLA status is still red
Please feel free to re-open this

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants